Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wesnoth commands report #2500

Open
ProditorMagnus opened this issue Feb 13, 2018 · 17 comments

Comments

@ProditorMagnus
Copy link
Contributor

@ProditorMagnus ProditorMagnus commented Feb 13, 2018

I marked with box those that I think need action.

Missing help entry

  • benchmark
  • theme

Incomplete help

  • friend accepts note after name
  • report alias is query adminmsg, in addition to just adminmsg

Unneeded

  • controller - Lua and WML have access to it
  • details
  • drop
  • register
  • set

Room commands do nothing on 1.13, regression - though they have extremely limited use even in 1.12

  • join
  • names
  • part
  • room
  • room_query - topic at least doesnt work on 1.12 either
  • rooms

Untested

  • create - alternate for create unit menu?
  • throw - I guess same as fire_event as called from lua

Misc

  • control/give_control - needs GUI access as well for 1.14
  • "q" does not give help message that it is supposed to - when writing out query, or "q ", then that works
  • log - unsure what domains and levels exist
  • refresh - not sure what it does
  • whiteboard, whiteboard_options - I guess first one is same as planning mode, second one if it still works should be reachable from same menu
  • alias does not work when used with /
  • benchmark and fps are duplicates
@stevecotton

This comment has been minimized.

Copy link
Contributor

@stevecotton stevecotton commented Feb 13, 2018

Half of those can't be fixed during a string freeze. :(

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor Author

@ProditorMagnus ProditorMagnus commented Feb 13, 2018

Only give_control GUI access is such that would be needed for 1.14.

@soliton-

This comment has been minimized.

Copy link
Member

@soliton- soliton- commented Feb 13, 2018

Perhaps not so great to have that many different issues in one report. Thanks for the overview nevertheless.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

@CelticMinstrel CelticMinstrel commented Feb 14, 2018

If the GUI access can be done using only existing strings, sure?

@doofus-01

This comment has been minimized.

Copy link
Member

@doofus-01 doofus-01 commented Feb 17, 2018

I think "refresh" regenerates the image cache. It's useful for drawing/testing terrain or sprite images, not sure a regular player would have reason to use it though.

I think there used to be a command "sunset" that could have gone in the same category, but it doesn't seem to work anymore. Maybe I'm miss-remembering the name.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor Author

@ProditorMagnus ProditorMagnus commented Feb 17, 2018

Sunset I reported long time ago, gna 22979.

Follow-up Comment #2:

Sunset was removed in 1.13.7.

Follow-up Comment #1:

I'm not convinced this is actually a bug.

This appears to be an extremely old debugging aid for developers, the purpose
is to help visualize what pixels are being redrawn during screen refresh
events. It might also be useful to see this during the main menu and such,
it's hard to say. I don't think it is intended to be used ever by users or
even WML developers.

Regardless I am downgrading the importance of this.

@doofus-01

This comment has been minimized.

Copy link
Member

@doofus-01 doofus-01 commented Feb 18, 2018

Those links must be unintentional? I recall finding sunset useful once or twice, so I don't think it was a completely useless relic from early development, but I'm not arguing that it should be brought back.

"Refresh" certainly isn't useless, even if players and WML/Lua developers have no use for it. Please don't remove it. (Not that anyone said they were going to, but just in case anyone was getting that idea from the "sunset" stuff.)

@Vultraz

This comment has been minimized.

Copy link
Member

@Vultraz Vultraz commented Feb 21, 2018

refresh is very useful. It does as @doofus-01 says and purges the image cache.

@ProditorMagnus ProditorMagnus referenced this issue Feb 22, 2018
3 of 6 tasks complete
@Vultraz

This comment has been minimized.

Copy link
Member

@Vultraz Vultraz commented Feb 25, 2018

References to #2049.

@Pentarctagon

This comment has been minimized.

Copy link
Member

@Pentarctagon Pentarctagon commented Aug 17, 2019

give_control has a GUI now.

@Pentarctagon

This comment has been minimized.

Copy link
Member

@Pentarctagon Pentarctagon commented Aug 30, 2019

details, drop, register, and set are resolved, as they no longer exist as of #4247

@Pentarctagon

This comment has been minimized.

Copy link
Member

@Pentarctagon Pentarctagon commented Aug 30, 2019

As for the room commands, what exactly was their purpose? If they aren't currently functional and aren't especially useful anyway, perhaps they could simply be removed as well.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor Author

@ProditorMagnus ProditorMagnus commented Aug 30, 2019

It was equivalent of irc channels.

jostephd added a commit that referenced this issue Sep 11, 2019
@jostephd

This comment has been minimized.

Copy link
Member

@jostephd jostephd commented Sep 11, 2019

Added theme, create, throw in 90f69b0.

@jostephd

This comment has been minimized.

Copy link
Member

@jostephd jostephd commented Sep 11, 2019

[ ] benchmark and fps are duplicates

They aren't, actually - :fps toggles the preferences, :benchmark is a one-off, toggles a few things that :fps doesn't (see display.cpp) - but yes, it's confusing. There's already a checkbox for documenting benchmark so I'll mark this duplication as done.

@Pentarctagon

This comment has been minimized.

Copy link
Member

@Pentarctagon Pentarctagon commented Sep 12, 2019

I'll probably be removing what remains of the room commands once 1.16 is close to release, unless anyone would still prefer to keep that around.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor Author

@ProditorMagnus ProditorMagnus commented Sep 13, 2019

give_control has a GUI now.

I mean GUI to open the GUI it has, so something in menu or actions.

jostephd added a commit that referenced this issue Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.