Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching ToD images in {SUMMER_SCHEDULE} and {WINTER_SCHEDULE} #2677

Closed
CelticMinstrel opened this issue Mar 17, 2018 · 19 comments

Comments

Projects
None yet
5 participants
@CelticMinstrel
Copy link
Member

commented Mar 17, 2018

Either revert 443339d or update the 24-hour schedule images to match.

@Vultraz

This comment has been minimized.

Copy link
Member

commented Mar 17, 2018

Don't use Urgent for something like this.

@Vultraz Vultraz removed the Urgent label Mar 17, 2018

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2018

It's totally urgent, but whatever.

@doofus-01 doofus-01 added the Graphics label Mar 18, 2018

@doofus-01

This comment has been minimized.

Copy link
Member

commented Mar 18, 2018

The good news is we can swap out images even in stable branch. The image change may have been premature, but if it spurs some action, it's not all bad. If this is a mistake, we won't be stuck with it for the next four years, or whenever 1.16 comes out.
Adding graphics tag so I might find it some day later.

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2018

I'll add that a third option would be to simply not use 24-hour schedule images for {MIDDAY} and {MIDNIGHT} and instead use images that better match the new ToD images.

Still, the best option would be to update all built-in schedules (including the two-suns schedule!).

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

It's been nearly a year. Any update on this?

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

I'm not sure... I don't think they quite match the default schedule's graphics, though? So while that approach should work for an updated 24-hour schedule, I'm not sure it'll work for midnight and midday.

@Vultraz

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

I created the new default schedule images by taking one of the base sky images, cropping it to the right size, and adding some of the cloud overlays manually.

But honestly, this is still an incredibly minor issue. I think we should just forget it.

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

No, it's not an "incredibly minor" issue. It's not a major issue either, but it's not at the level of being unworthy of attention.

Anyway, from what you said it sounds like we can pretty easily make at least midday and midnight images using the same process you used for the other times of day.

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

There are already midday/midnight images in WoV:
https://github.com/sigurdfdragon/Wings_of_Victory/blob/master/images/misc/schedule-midday.png
https://github.com/sigurdfdragon/Wings_of_Victory/blob/master/images/misc/schedule-midnight.png
They're also being added as part of #3977. However, since that PR is for master only, I suggest to cherry-pick those two images to master+1.14 in order to make the winter/summer schedules internally consistent.

@sigurdfdragon @CelticMinstrel okay?

@jostephd jostephd added this to the 1.14.7 milestone Mar 21, 2019

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

Sounds good! I assume they do fit with the rest of the schedules, right?

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

I'd say so, yes. See for yourself:

WoV:

2019-03-22-001119_1920x1080_scrot

mainline SUMMER_SCHEDULE:

2019-03-22-001232_1920x1080_scrot

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

The midnight one really stands out, but I suppose that's because I'm looking at summer schedule, not winter schedule...

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Here's the winter schedule.

2019-03-22-115740_1920x1080_scrot

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

Okay yeah, looks good. (I think the mainline summer/winter schedules only contain one each of midday/midnight though, don't they?)

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

The schedules are exactly as shown in the screenshots:

#define SUMMER_SCHEDULE
{DAWN} {TOD_COLOR_SHIFT 0 -10 -5}
{MORNING} {TOD_COLOR_SHIFT 5 5 0}
{MIDDAY} {TOD_COLOR_SHIFT 5 5 0}
{AFTERNOON} {TOD_COLOR_SHIFT 5 5 0}
{DUSK}
{MIDNIGHT}
#enddef
#define WINTER_SCHEDULE
{DAWN} {TOD_COLOR_SHIFT -30 -15 5}
{MIDDAY} {TOD_COLOR_SHIFT -5 -5 5}
{DUSK} {TOD_COLOR_SHIFT 5 -20 -30}
{FIRST_WATCH}
{MIDNIGHT}
{SECOND_WATCH}
#enddef

@CelticMinstrel

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

Oh, okay. In any case, they're fine, so please go ahead and commit them.

Now all we need is updated 24-hour schedule images and updated 2-suns schedule images... but those are less important since they're at least internally consistent. Oh, and maybe updated images for the special schedules (indoors, underground, etc).

@sigurdfdragon

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

FTR, the midday & midnight images are originally from https://forums.wesnoth.org/viewtopic.php?p=633042#p633042

jostephd added a commit that referenced this issue Mar 24, 2019

Fix #2677: Make SUMMER_SCHEDULE and WINTER_SCHEDULE use {MIDDAY} and …
…{MIDNIGHT} images of the same graphic style as the images of the other times of day.

Images by @beetlenaut https://forums.wesnoth.org/viewtopic.php?p=633042#p633042

jostephd added a commit that referenced this issue Mar 24, 2019

@jostephd jostephd closed this in 5502f7a Mar 24, 2019

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Thanks for the link @sigurdfdragon. Okay, committed and backported. @beetlenaut, thanks for making those images. @CelticMinstrel, I agree, the other schedules are internally consistent, we can have a new issue for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.