Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons below minimap don't work anymore #2681

Closed
ePaul opened this issue Mar 18, 2018 · 1 comment
Closed

Buttons below minimap don't work anymore #2681

ePaul opened this issue Mar 18, 2018 · 1 comment

Comments

@ePaul
Copy link
Contributor

@ePaul ePaul commented Mar 18, 2018

Current version: 1.15.0-dev (3555b62) (build myself today)
(Though I noticed this with previous builds too, for some weeks now.)

Wrong behavior
wesnoth-minimap-buttons

Clicking on any of the buttons below the minimap (apart from the left-most one) doesn't do anything.
(They still have tooltips showing what they are supposed to do.)

Expected behavior

When clicking one of the buttons, something changes in the minimap:

  • (change the zoom level of the main map (this one works))
  • change whether terrain is displayed
  • change whether units are displayed
  • change whether villages are displayed
  • change the color of units in the minimap
  • change the way terrain is displayed
@jyrkive jyrkive closed this in 750d558 Mar 18, 2018
jyrkive added a commit that referenced this issue Mar 18, 2018
Regression from commit ecc0dca.
@ePaul

This comment has been minimized.

Copy link
Contributor Author

@ePaul ePaul commented Mar 18, 2018

It works now on the 1.14 branch (I tried 0ab238a).

In master I got compilation errors (both at 61f653f and 750d558), though that might not be related to the commit. In f97a617 it compiles again and works, too.

Thanks.

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
Regression from commit ecc0dca.

(cherry-picked from commit 750d558)
@jostephd jostephd mentioned this issue Oct 14, 2018
959 of 959 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.