Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private chats get lost when joining or leaving a game #2802

Closed
vgaming opened this issue Mar 31, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@vgaming
Copy link
Member

commented Mar 31, 2018

Subj. Private chats get permanently lost, along with all their contents, if you join or leave any game (possibly observe too).
The chat tabs just disappear, and everything written in them too.

@vgaming vgaming added the Bug label Mar 31, 2018

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2018

I personally think it's a Breaker, can't release 1.14 with that.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2018

Public chats as well.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2018

re #2538, especially #1194

@gfgtdf

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2018

is this this behaiopur different from 1.12

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2018

@gfgtdf yes, because on 1.12 there were no real "private chat" tabs, so all was written in lobby. Lobby was retained.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2018

With 1.12 you only lose private messages sent to you while you were in game.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2018

UPD: currently, the public chat is lost as well. I think we need to retain all of it: the public chat, the private chats.
Adding blocker label since I think this is a blocker.

@Vultraz Vultraz self-assigned this Apr 1, 2018

@gfgtdf gfgtdf added this to the 1.14.0 milestone Apr 2, 2018

@jyrkive

This comment has been minimized.

Copy link
Member

commented Apr 16, 2018

Unassigning due to lack of progress.

@jyrkive

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

I implemented saving and restoring public and private chats in commit 8a00276.

@jyrkive jyrkive closed this Apr 17, 2018

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2018

Staging chat, "this game" is not saved/restored currently.

@Vultraz

This comment has been minimized.

Copy link
Member

commented Apr 26, 2018

Intended and expected.

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

@jostephd jostephd referenced this issue Oct 14, 2018

Closed

Forward-port 1.14 to development #3614

959 of 959 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.