Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help contains dead link to the "Great River #2963

Open
sevu opened this issue Apr 25, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@sevu
Copy link
Member

commented Apr 25, 2018

There are a few links in the help to the Great River, but no such Topic exists. Or does it only exist in a campaign?

(There is as well an dead link for Castle, but this should just be removed)

@sevu sevu added the Prose label Apr 25, 2018

@Vultraz

This comment has been minimized.

Copy link
Member

commented Apr 26, 2018

I've tried many times to fix those... never been able to :(

@shikadiqueen shikadiqueen added the Bug label Apr 26, 2018

@Wedge009 Wedge009 added the Help label May 3, 2018

@sevu

This comment has been minimized.

Copy link
Member Author

commented May 14, 2018

Cave (as topic containing different ones) and cave hills link to an non-existent illuminated

@sevu

This comment has been minimized.

Copy link
Member Author

commented May 22, 2018

text='Deserts' have a somewhat different composition than small sand pits or beaches, however for gameplay purposes they are identical. See dst='terrain_sand' text='sand'.

terrain_sand_beach would be a valid destination. How can I find out what the dst would have to be if I want to link to the page in the help which contains all sand terrains?

jostephd added a commit that referenced this issue Oct 22, 2018

jostephd added a commit that referenced this issue Oct 22, 2018

jostephd added a commit that referenced this issue Oct 22, 2018

jostephd added a commit that referenced this issue Oct 22, 2018

@sevu sevu closed this Mar 28, 2019

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@sevu There were four separate bugs identified here:

  • Dead links to "Great River" (fixed by me)
  • Dead links to "Castle" - is that still a problem? What help page are the links on? How can I find out?
  • Broken link from Desert to Sand (fixed by me)
  • Cave broken link to illuminated (outstanding)

Could you open a new issue for the outstanding parts?

@sevu

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

I checked, they are fixed as well

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 30, 2019

I checked, they are fixed as well

So did I. I couldn't check the castle link because you never said where it was, but the cave link is not fixed, see for yourself:

2019-03-30-161237_432x164_scrot

That's with master as of today. Note that you need to run wesnoth --debug to see it in red. Without --debug the text appears as a non-link (white font).

@sevu

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

That's with master as of today. Note that you need to run wesnoth --debug to see it in red. Without --debug the text appears as a non-link (white font).

That explains things… I'll check about it again.

@jostephd jostephd reopened this Mar 30, 2019

@jostephd jostephd removed their assignment Apr 3, 2019

@sevu sevu self-assigned this Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.