New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "End of file" error on the client when server crashes/disconnects #3005

Closed
shikadiqueen opened this Issue May 3, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@shikadiqueen
Member

shikadiqueen commented May 3, 2018

When the server crashes or otherwise disconnects clients unexpectedly, clients report this with a transient UI message simply stating "End of file". This does not make sense to the average player and needs to be replaced with an actual error message.

@shikadiqueen shikadiqueen added this to the 1.14.1 milestone May 3, 2018

@shikadiqueen shikadiqueen self-assigned this May 3, 2018

shikadiqueen added a commit that referenced this issue May 4, 2018

mp: Improve display of wesnothd client errors in general
Besides replacing the "End of file" error when getting disconnected from
the server under unexpected circumstances (e.g. because the server died)
with a translatable and more intuitive message, this also makes it so
other network error messages ("Connection refused", "Host not found",
etcetera) are displayed in the UI in a slightly clearer fashion, and in
an error dialog that must be dismissed with a click on a button, instead
of a transient message that can be easily missed due to an accidental
misclick.

Closes #3005.

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

mp: Improve display of wesnothd client errors in general
Besides replacing the "End of file" error when getting disconnected from
the server under unexpected circumstances (e.g. because the server died)
with a translatable and more intuitive message, this also makes it so
other network error messages ("Connection refused", "Host not found",
etcetera) are displayed in the UI in a slightly clearer fashion, and in
an error dialog that must be dismissed with a click on a button, instead
of a transient message that can be easily missed due to an accidental
misclick.

Closes wesnoth#3005.

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

mp: Improve display of wesnothd client errors in general
Besides replacing the "End of file" error when getting disconnected from
the server under unexpected circumstances (e.g. because the server died)
with a translatable and more intuitive message, this also makes it so
other network error messages ("Connection refused", "Host not found",
etcetera) are displayed in the UI in a slightly clearer fashion, and in
an error dialog that must be dismissed with a click on a button, instead
of a transient message that can be easily missed due to an accidental
misclick.

Closes wesnoth#3005.

(cherry-picked from commit c503c2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment