Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SotA - Against the World, Nagas say Saurians line of text #3294

Closed
Konrad22 opened this Issue Jun 30, 2018 · 17 comments

Comments

Projects
None yet
5 participants
@Konrad22
Copy link
Contributor

Konrad22 commented Jun 30, 2018

The Nagas say that they are mad at me for killing their males. But. Every single enemy Naga is male, instead of, let's say, female. Which would mage more sense, story wise.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Jul 1, 2018

Just checking, but how do you know they're male? (I know the nagas don't have differing male/female sprites, though I think there is some way to distinguish.)

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 1, 2018

The name of the unit.
Male ones are called 'Naga ...' and female ones are 'Nagini ...'.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Jul 1, 2018

Well, in any case it seems like it should be relatively easy to make them all female.

@sigurdfdragon sigurdfdragon self-assigned this Jul 1, 2018

sigurdfdragon added a commit that referenced this issue Jul 4, 2018

SotA S11 & 21: Fix #3294
Adjust units to have appropriate gender for story reasons.
@beetlenaut

This comment has been minimized.

Copy link
Member

beetlenaut commented Jul 21, 2018

Oops. It was supposed to be the saurian that says that. It was the saurians whose males got killed in the swamp. This wasn't supposed to apply to the nagas at all.

@sigurdfdragon

This comment has been minimized.

Copy link
Contributor

sigurdfdragon commented Jul 21, 2018

Noted. No ideas at the moment for what, if anything, to do.

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 21, 2018

Ohhh, right, I remember.
Uh. So, change it, so the saurians says it and randomize the gender of the Naga? ^^ There still is no reason why all of their warriors should be the same gender. :D

@Konrad22 Konrad22 changed the title SotA - Against the World, Nagas have the wrong gender SotA - Against the World, Nagas say Saurians line of text Jul 23, 2018

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 25, 2018

@sigurdfdragon Would you mind reopening the issue? After all, you apparently fixed something that wasn't wrong, because I misunderstood the issue and managed to convince everyone. xD
The actual issue now still exists, right?

@sigurdfdragon

This comment has been minimized.

Copy link
Contributor

sigurdfdragon commented Jul 25, 2018

@Konrad22 @beetlenaut

All Saurian units are not specified/male gender. (can't see a difference like one can for the nagas via name) Do we think that would play well enough with having them say the dialog? If so, I'll reopen this and do something about it.

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 25, 2018

@sigurdfdragon
Well, we certainly are sure, that the Nagas are saying a line that actually belongs to the saurians (and that does partially make no sense for the Nagas)...but if we take that line from them, then the Nagas just arrive on the battlefield, saying nothing. That's kinda random too.
So I actually hope for more information. I do think that maybe the Saurians were actually meant to arrive on turn 1, with the Nagas arriving on turn 2. The Saurians saying their actual line and the Nagas saying the line the Saurians are saying presently. That way it makes the most sense to me.
If the others agree, then I'd like you to change it in this way. :)

@beetlenaut

This comment has been minimized.

Copy link
Member

beetlenaut commented Jul 26, 2018

@sigurdfdragon @Konrad22 Don't take the whole line from the nagas, just "they killed our males". That's the part I messed up. The saurian should have said that. Everything else was correct.

Saurians definitely have males and females. The females do most of the fighting, and the males work magic. You fight only augurs and their advancements in the swamp because the superstitious females (the skirmishers) have left. And, you kill almost all of them. That's what the line is supposed to refer to.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Jul 26, 2018

If that's the lore, I wonder if we should add the gender key to all the Saurian unit type definitions? I mean add gender=male to the augur line units and gender=female to the skirmisher line units, so that the sidebar text will also support the campaign's assertion that all the augurs are male (if you're playing in a more gendered language than English, at least).

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 26, 2018

That would be neat.

@sigurdfdragon sigurdfdragon reopened this Jul 27, 2018

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 27, 2018

It would be also very good, if you'd removed the saurian mages from the recruit list, after all all their males (the mages) are supposed to be dead. While there is no gender tag for saurians yet, the wiki does have a nice description of saurians, saying the the mages are male and the skirmishers are female.
This is not part of the ingame help description, but the scenario 'Battleground' (which is the reason the saurians are attacking you now) does seem to have had this wiki in mind, because you fight only against saurian mages there.

@sigurdfdragon

This comment has been minimized.

Copy link
Contributor

sigurdfdragon commented Jul 28, 2018

Ok, so it seems like a proper fix would be the following:
Dialog changes for S21

    [message]
        speaker=Taxtrimon
        message= _ "We have found them! These magi destroyed a profitable business venture. We will take vengeance. You horse humans can assist us."
    [/message]

    [message]
        speaker=Fizztsars
        message= _ "We have arrived, Taxsstrimon. We will fight bessside you. They will pay for killing our malesss!"  # no spellcheck
    [/message]

(This next line is same as before)
[message]
speaker=Taxtrimon
message= _ "Well met Fizztsars. Now these creatures will certainly fall."
[/message]

Have Saurians only recruit skirmishers & ambushers in S21

Undo the naga gender change commits in S11 & S21
add a mix of genders in the placed nagas in S21

@beetlenaut @CelticMinstrel @Konrad22 Sound good?

@beetlenaut

This comment has been minimized.

Copy link
Member

beetlenaut commented Jul 28, 2018

Yes, that sounds good.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

CelticMinstrel commented Jul 28, 2018

Not sure why you're asking me or Konrad, but I have no problem with it.

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

Konrad22 commented Jul 28, 2018

It's exactly what I had in mind, thank you. :)

sigurdfdragon added a commit that referenced this issue Jul 29, 2018

Revert "SotA S11 & 21: Fix #3294"
This reverts commit a4bad90.

It is supposed to be the male Saurians that get killed in S11, and the
females seek revenge in S21.

sigurdfdragon added a commit that referenced this issue Jul 29, 2018

SotA S21: Fix #3294 properly
It is the Saurians that have their males killed in S11, so the females
take revenge.

sigurdfdragon added a commit that referenced this issue Jul 29, 2018

SotA S21: Fix #3294 properly
It is the Saurians that have their males killed in S11, so the females
take revenge.

@sevu sevu added this to the 1.14.5 milestone Sep 14, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

SotA S11 & 21: Fix wesnoth#3294
Adjust units to have appropriate gender for story reasons.

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

Revert "SotA S11 & 21: Fix wesnoth#3294"
This reverts commit a4bad90.

It is supposed to be the male Saurians that get killed in S11, and the
females seek revenge in S21.

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

SotA S21: Fix wesnoth#3294 properly
It is the Saurians that have their males killed in S11, so the females
take revenge.

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

SotA S11 & 21: Fix wesnoth#3294
Adjust units to have appropriate gender for story reasons.

(cherry-picked from commit 2f710f8)

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

Revert "SotA S11 & 21: Fix wesnoth#3294"
This reverts commit a4bad90.

It is supposed to be the male Saurians that get killed in S11, and the
females seek revenge in S21.

(cherry-picked from commit 7ced358)

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

SotA S21: Fix wesnoth#3294 properly
It is the Saurians that have their males killed in S11, so the females
take revenge.

(cherry-picked from commit 32a630b)

@jostephd jostephd referenced this issue Oct 14, 2018

Closed

Forward-port 1.14 to development #3614

959 of 959 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.