New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failure when attacking #3424

Closed
CelticMinstrel opened this Issue Aug 3, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@CelticMinstrel
Member

CelticMinstrel commented Aug 3, 2018

If you attempt to attack with a unit whose attacks all have attack_weight=0, there is an assertion failure in the GUI2 listbox. I haven't tested but it might also apply if the unit's attacks all have an active [disabled] weapon special.

jostephd added a commit to jostephd/wesnoth that referenced this issue Aug 3, 2018

@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd
Member

jostephd commented Aug 3, 2018

jyrkive added a commit that referenced this issue Aug 3, 2018

@vgaming

This comment has been minimized.

Show comment
Hide comment
@vgaming

vgaming Aug 3, 2018

Contributor

@jostephd you're referencing the very same issue we're now in.

Contributor

vgaming commented Aug 3, 2018

@jostephd you're referencing the very same issue we're now in.

@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd

jostephd Aug 3, 2018

Member

Whoops. Fixed.

Member

jostephd commented Aug 3, 2018

Whoops. Fixed.

@jyrkive jyrkive closed this in f293c7c Aug 3, 2018

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Aug 3, 2018

Member

Wow that was fast! \o/

Member

CelticMinstrel commented Aug 3, 2018

Wow that was fast! \o/

@sevu sevu added this to the 1.14.5 milestone Sep 14, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment