New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units' haloes are not removed on death after an animation is played #3509

Closed
DisherProject opened this Issue Aug 29, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@DisherProject
Contributor

DisherProject commented Aug 29, 2018

I'm playing Wesnoth 1.14.4 on Windows 10

To reproduce:

  1. Start "The hammer of Thursagan"
  2. Jump to the 9th scenario "Forbidden Forest" by typing :debug and :choose_level
  3. Create a Mage of Light (shift + C) next to the temple in the middle of the map
  4. Move him on it to let him take the staff
  5. Kill the mage (shift + K)

The mage's halo will remain where it is. Reloading the map will remove it.

Another way to reproduce this bug is the one that follows:

  1. Download this version of the Caves of the Basilisk and replace it with the original one (i've added some events at the end of the file)
    2p_Caves_of_the_Basilisk.zip
  2. Start the Caves of the Basilisk
  3. Move your Mage of Light on the signpost
  4. Do whatever you want with him (attack someone, move him...) then kill him

His halo won't be undrawn. You can try with other units with haloes, like Elvish Shydes: the result will be the same

@newfrenchy83

This comment has been minimized.

Show comment
Hide comment
@newfrenchy83

newfrenchy83 Sep 5, 2018

Contributor

I am post an PR for tesolve this.

Contributor

newfrenchy83 commented Sep 5, 2018

I am post an PR for tesolve this.

jyrkive added a commit that referenced this issue Sep 6, 2018

[animate_unit]: clear the animation after playing it
This avoids a reference to the unit from being leaked, which prevented the
unit's halo (if any) from disappearing when the unit died.

Fixes #3509. Closes #3520.

@jyrkive jyrkive closed this in e63bd35 Sep 6, 2018

@sevu sevu added Bug Graphics labels Sep 14, 2018

@sevu sevu added this to the 1.14.5 milestone Sep 14, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

[animate_unit]: clear the animation after playing it
This avoids a reference to the unit from being leaked, which prevented the
unit's halo (if any) from disappearing when the unit died.

Fixes wesnoth#3509. Closes wesnoth#3520.

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

[animate_unit]: clear the animation after playing it
This avoids a reference to the unit from being leaked, which prevented the
unit's halo (if any) from disappearing when the unit died.

Fixes wesnoth#3509. Closes wesnoth#3520.

(cherry-picked from commit e63bd35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment