New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random start time option does not work #3515

Closed
betrok opened this Issue Sep 1, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@betrok

betrok commented Sep 1, 2018

MP scenarios seem to always start at dawn regardless this setting.

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Sep 1, 2018

Contributor

hm yes known issue, seems like we forgot it

heh turned out this happens really randomly, random gnerator has some high chance to produce an invalid number in which case the code jsut set it to the first start time.

Contributor

gfgtdf commented Sep 1, 2018

hm yes known issue, seems like we forgot it

heh turned out this happens really randomly, random gnerator has some high chance to produce an invalid number in which case the code jsut set it to the first start time.

gfgtdf added a commit that referenced this issue Sep 5, 2018

@jyrkive jyrkive closed this in 8ed6014 Sep 6, 2018

@vgaming

This comment has been minimized.

Show comment
Hide comment
@vgaming

vgaming Sep 12, 2018

Contributor

@jyrkive thanks! Is the fix OOS-safe? Can I re-compile and start playing online with the newer version?

Contributor

vgaming commented Sep 12, 2018

@jyrkive thanks! Is the fix OOS-safe? Can I re-compile and start playing online with the newer version?

@sevu sevu added this to the 1.14.5 milestone Sep 14, 2018

@sevu sevu added the Bug label Sep 14, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

fix wesnoth#3515 : random start time
(cherry-picked from commit 8ed6014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment