New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparing tstring to a string crashes the game. #3541

Closed
gfgtdf opened this Issue Sep 10, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@gfgtdf
Contributor

gfgtdf commented Sep 10, 2018

reproduced on 1.14.4, comparing tstring lua userdata to a lua string crashes the game. _("a") < "a"

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Sep 10, 2018

Contributor

fixed by 71a6f62 seems like i forgot the # in the commit message.

Contributor

gfgtdf commented Sep 10, 2018

fixed by 71a6f62 seems like i forgot the # in the commit message.

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Sep 10, 2018

Member

I closed this since gfgtdf said it was fixed, but then noticed it was only fixed on 1.14, so reopening until it's forward-ported.

Member

CelticMinstrel commented Sep 10, 2018

I closed this since gfgtdf said it was fixed, but then noticed it was only fixed on 1.14, so reopening until it's forward-ported.

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf
Contributor

gfgtdf commented Sep 10, 2018

@gfgtdf gfgtdf closed this Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment