Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice continues playing even when skipped #3832

Open
FranPrin opened this issue Jan 4, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@FranPrin
Copy link

commented Jan 4, 2019

I am using the voice= tag in the story of my scenario and receiving an issue. Here is the code that I am using:

        [part]
            story= _ "Years pass. Every summer when the mountain passes become clear, the lich sends his soldiers to attack the orcs, removing any human, elven, or dwarvish patrols that get in the way. Every year the undead inflict some damage before being repelled and retreating to the caves."
            {STORYTXT_BACKGROUND end.jpg}

	     voice=decent_into_darkness/Descent121.ogg

        [/part]

But if I press the "skip" button while the sound file is playing, it continues to play even while the scenario is running. This is a bad behavior because then the voice over is playing while you are moving your units.

gfgtdf suggested I post this as a bug here.

Thank you!

@jostephd

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

Liberty plays music during the story that continues playing during turn 1 if the player skips the story, and in that case I like that behavior. However, it uses [sound] tags, not [part] voice= tags, so the behavior is expected in that case.

[sound]
name=ambient/wardrums.ogg
repeat=3
[/sound]
[message]
speaker=Baldras
message= _ "We need evidence. Hard evidence... but wait— Are those orcish war drums I hear?"
[/message]

@jostephd

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

@sevu What additional info is needed?

@sevu

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

Ah, I misread, none.
Your example does not fit though, it's not using [part] tags with sound attributes.

@sevu sevu added Bug and removed Needs more info labels Jan 6, 2019

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

I looked at the code for this and noticed that it's not even adding a sound source (as the equivalent code in [c][message][/c] does) but just directly playing a positioned sound. I think the entire reason for using a position sound is to make use of the sound ID to allow the sound to be stopped, so I guess what you'd need to do is add another call to stop the voice when the dialog exits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.