New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game crash in multiplayer lobby #3859

Open
FranPrin opened this Issue Jan 9, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@FranPrin
Copy link

FranPrin commented Jan 9, 2019

I'm getting an odd problem and was wondering if anyone else has?

In the multiplayer lobby if I join a game that has add-ons that I don't have then it says "connnecting to add-on server" and attempts to connect.

If, however, I press 'cancel' while it is connecting to the server the entire game dies instantly. This happened twice yesterday and the log files say "Caught unspecified general exception. Terminating."

I don't know if this error has already been reported but it is pretty severe to have the entire game die.

I am using the latest wesnoth 1.14.5 btw

@jostephd

This comment has been minimized.

Copy link
Member

jostephd commented Jan 9, 2019

Confirmed on latest 1.14 from git.

@gfgtdf

This comment has been minimized.

Copy link
Contributor

gfgtdf commented Jan 9, 2019

This means someone forgot to make their exception derive from std::exception

@jostephd

This comment has been minimized.

Copy link
Member

jostephd commented Jan 10, 2019

It's throwing addon_client::user_disconnect, but if I make it derive from std::exception it's still only caught in main(). Haven't looked further yet.

@jostephd jostephd added this to the 1.14.6 milestone Jan 10, 2019

@gfgtdf

This comment has been minimized.

Copy link
Contributor

gfgtdf commented Jan 10, 2019

yes, the actual bug of not catching it should also be fixed, but all classes that are thrown should derive from std::exception to make debugging easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment