Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Question] Backport Damage type and range icons from master? #4062
I recently noticed that there is new Damage type and range icons feature in master branch.
This feature is from @jostephd and I like it. So as 1.15 and 1.16 don't seems to be released anytime soon I want to discuss if we could backport this feature to 1.14 .
Project for that feature: https://github.com/wesnoth/wesnoth/projects/4
1.15 from 4d16836
1.14 from 4ce5b52
Things which I have to mention
There are icons for the standard ranges (melee/ranged) and damage types (arcane/cold/fire/blade/impact/pierce). Your screenshot shows a unit that uses a custom range, "electrical", which doesn't have an image, so the code falls back to the texty display. That is important for compatibility with existing UMC that uses custom ranges or damage types (like Era of Magic).