Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Backport Damage type and range icons from master? #4062

Open
hrubymar10 opened this issue May 6, 2019 · 3 comments

Comments

3 participants
@hrubymar10
Copy link
Member

commented May 6, 2019

Brief

I recently noticed that there is new Damage type and range icons feature in master branch.

This feature is from @jostephd and I like it. So as 1.15 and 1.16 don't seems to be released anytime soon I want to discuss if we could backport this feature to 1.14 .

Project for that feature: https://github.com/wesnoth/wesnoth/projects/4

Screenshots:

1.15 from 4d16836

image

1.14 from 4ce5b52

image

Things which I have to mention

  • (@jostephd ) If a unit has two attacks, one of the attacks has mainline ranges/types and one attack has custom ranges/types, then it'd look a bit funny... That's the only downside to backporting that I can think of.
  • (@hrubymar10 ) Icons makes the space for text smaller. It could be problem for some longer texts
  • (@hrubymar10 ) There are some icons missing (for example in case of lightning (magic attack))

Ping

@jostephd , @Vultraz , @jyrkive and anyone else who has opinion

@jostephd

This comment has been minimized.

Copy link
Member

commented May 6, 2019

(@hrubymar10 ) There are some icons missing (for example in case of lightning (magic attack))

There are icons for the standard ranges (melee/ranged) and damage types (arcane/cold/fire/blade/impact/pierce). Your screenshot shows a unit that uses a custom range, "electrical", which doesn't have an image, so the code falls back to the texty display. That is important for compatibility with existing UMC that uses custom ranges or damage types (like Era of Magic).

@hrubymar10

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

Also this feature will be real advantage for iOS version, especially the iPhone version. This feature makes height of attack smaller so attack informations could fit even in smaller displays.

@singalen ^^

@jyrkive

This comment has been minimized.

Copy link
Member

commented May 6, 2019

I don't really have an opinion about backporting the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.