Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcolors for teams >9 #4123

Open
sevu opened this issue Jun 17, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@sevu
Copy link
Member

commented Jun 17, 2019

Currently all teams >= 9 get teal as color. data/core/team-colors.cfg knows 6 more colors though, which can be set by WML. (even more with the terrain colors, which I didn't look at)
Proposal: moving the border to 15.

Comparision of colors – first line being the 9 default ones:
team-colors

  • lightblue: easy to spot
  • gold: easy to spot on map, a bit less on minimap
  • brightorange: same, but similar to gold
  • darkred: not similar to red, thouth can't be distinguished on minimap
  • lightred: same, but easy to mix with brown + orange
  • brightgreen: easy to spot

Possible numbering:

  • 10 gold
  • 11 lightblue
  • 12 brightgreen
  • 13 darkred
  • 14 brightorange
  • 15+ lightred

other notes:

  • In the MP game setup colors 1-9 can be choosen in the pull down list. If one of the other colors is specified by WML, then it are 10 in this one pulldown only. That can stay as is, keeping the pulldown short.
  • minimap color for lightred and darkred seems to be a bug.
@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

When adding new color mappings, would be nice to define more colors too like https://github.com/ProditorMagnus/Color_Modification/blob/master/color_mod.cfg (pink and yellow especially)

@sevu sevu modified the milestones: 1.15.0, 1.16.0 Jun 20, 2019

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

minimap color for lightred and darkred seems to be a bug.

If I recall correctly, the fourth colour in the [color_range] is used for minimap and text, so perhaps it needs tweaking?

Actually, as an aside, it might be nice to deprecate the rgb= key in [color_range] in favour of four separate descriptive keys that indicate exactly what each of the colours means. The way it currently stands makes it look like a range similar to the palettes, but in fact each of the four colours has a specific use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.