Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to save replay under different name #4164

Open
bobeff opened this issue Jul 12, 2019 · 5 comments

Comments

@bobeff
Copy link

commented Jul 12, 2019

At the end of a scenario it will be good to have a option to save the replay under a different name in order to not override the previous replay. Also the default proposed name of the replay can contain the difficulty on which the scenario is completed and in the case that the difficulty is the same to contain some number which to make it unique. For example: AOI-Showdown replay (High Lord) (2) can indicate that this is a replay of the second completion of the Showdown scenario of the An Orcish Incursion campaign on the High Lord difficulty.

@jostephd

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

At the end of a scenario it will be good to have a option to save the replay under a different name in order to not override the previous replay

If a previous replay exists, you're prompted whether to overwrite it, and if you say not to overwrite, you're prompted to enter an alternate filename to save the replay under. Can you clarify what you're proposing to add?

Simply adding a number could be confusing, for example, TSG-A Choice in the Fog (Soldier) (2) might correspond to TSG-Pebbles in the Flood (Soldier) (1) because the campaign has forking paths.

@bobeff

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

If a previous replay exists, you're prompted whether to overwrite it, and if you say not to overwrite, you're prompted to enter an alternate filename to save the replay under.

I didn't know this. :) Because the prompt to enter an alternative filename is after the override option I didn't expect its existence. Maybe if the dialog with the filename is the first one, populated with some default filename, it will be more obvious. Then after pressing, Save if the entered filename already exists, the confirmation dialog for override can show. In the case the user chooses No, then it can be returned to the previous dialog. Which also can have an option for not saving a replay at all.

Simply adding a number could be confusing, for example, TSG-A Choice in the Fog (Soldier) (2) might correspond to TSG-Pebbles in the Flood (Soldier) (1) because the campaign has forking paths.

About the forked paths, obviously the filename can also contain some indicator which path was chosen.

@jostephd jostephd added Input UI labels Jul 15, 2019

@jostephd

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

I didn't know this. :) Because the prompt to enter an alternative filename is after the override option I didn't expect its existence. Maybe if the dialog with the filename is the first one, populated with some default filename, it will be more obvious. Then after pressing, Save if the entered filename already exists, the confirmation dialog for override can show. In the case the user chooses No, then it can be returned to the previous dialog. Which also can have an option for not saving a replay at all.

Sounds good. We could even check whether the prepopulated default filename exists when we first show the dialog. Maybe even only show the textbox for entering an alternative name if the default filename already exists (not sure about this).

About the forked paths, obviously the filename can also contain some indicator which path was chosen.

I was thinking of some "playthrough id", maybe an integer that's incremented every time you start the campaign (we could save it as a WML persistent variable), but yeah, there are many options here.

@bobeff

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

I was thinking of some "playthrough id", maybe an integer that's incremented every time you start the campaign

I don't think that this is a good idea, because when I played the campaigns, I didn't start the campaign from the beginning when I wanted to replay it through different path, but I loaded the last save before the fork. Maybe other players also do the same in their playthroughs.

@AI0867

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Campaign progression is a tree, any save can spawn any number of independent branches.

A way to deal with this would be to give each save an id, possibly a hash of the (decompressed) savefile, and then keeping track of all previous save ids. (just the last one is insufficient, as saves can be deleted, and might be autosaves)

Then based on that, you could reconstruct the playthrough tree, and add logic or UIs on top of that.

However, I think the original idea of (N) meaning the Nth completion of this scenario (not the campaign or playthrough) is probably sufficient for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.