Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable string "Sides %s and %d are tied." has hardcoded conjunct list #4274

Open
stevecotton opened this issue Aug 24, 2019 · 0 comments

Comments

@stevecotton
Copy link
Contributor

commented Aug 24, 2019

Low-priority, as having a match end in a 3-way tie sounds a rare occurrence; the reason for logging the issue is mainly that having the heterogeneous %s and %d looked wrong.

side_comparison = side_comparison .. string.format( "\n" .. tostring( _ "Sides %s and %d are tied."), table.concat(winning_sides, ", "), last_winning_side)

If sides 1 and 2 tie, then this will have "1" in the %s and 2 in the %d.
If sides 1, 2 and 3 tie, then this will have "1, 2" in the %s and 3 in the %d.

So the translation doesn't know how many sides there are, nor can it do a non-English-style format_conjunct_list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.