Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.15.1 Switching virtual desktops with full-screen wesnoth causes graphics issues #4309

Open
vgaming opened this issue Sep 3, 2019 · 27 comments

Comments

@vgaming
Copy link
Member

commented Sep 3, 2019

Steps to reproduce:

  • start wesnoth
  • open preferences > Display > enable "full-screen" checkbox
  • start any game
  • switch to another application
  • switch back to wesnoth

Expected at this point:

  • battlefield is shown normally

Actually:
2019 09 02_22:35:19

@jyrkive

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Which operating system do you use? This may well be OS specific (and even depend on your window manager if you use GNU/Linux).

@vgaming vgaming changed the title 1.15.1 switching away from wesnoth and bug makes graphics buggy 1.15.1 switching away from wesnoth and back makes graphics buggy Sep 3, 2019

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

@jyrkive I'm using ArchLinux, XFCE desktop environment, but no compositor (window manager) at all. (To be clear: yes, really, no compositor. Neither xfwm4 nor compton.)

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

When I hover the tiles, they get back to normal.

@jyrkive jyrkive added the Linux label Sep 3, 2019

@jyrkive

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

All right, I added the Linux label for now.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

I'm not able to reproduce this on Linux Mint 19.2.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

I tried to reproduce locally again, but on the first attempt, I couldn't (read further).

The problem apparently only appears if you have "Preferences -> Didsplay -> Full screen" checkbox enabled. In non-fullscreen mode, there's no such bug for me as well.

Can anybody please confirm the existence or not existence of this bug if said checkbox is enabled? (BTW, it is the default preference when people install wesnoth anew.)

@dvladf

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

I couldn't reproduce this problem (with fullscreen mode) on Kubuntu 18.04. Probably, this is specific for xfce.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

Very interesting. My system is XFCE indeed, but there's no window manager, so it should be identical to any other DE with no compositor. I'll check this bug with a compositor enabled in the evening.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

I'm still not able to reproduce the issue when switching between Wesnoth and TF2, whether either or both are fullscreen.

Does anything change if you do :refresh?

@jostephd

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

The minimap part looks similar to @Konrad22's screenshots on #4237/#4245.

And there's also #4196.

I use openbox on Debian, in case it matters.

edit: and #3006

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

I think this is a separate issue from Konrad22's reports. If I understand vgaming's original post correctly, this one happens generally, not in specific circumstances.

Edit: And I haven't been able to replicate this general-case problem.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

@Pentarctagon yes, if I enter :refresh, everything goes back to normal. Note that just "fullscreen" of the window manager is not enough. It's only the wesnoth-s built-in "refresh" checkbox that makes the graphics buggy for me.

@Wedge009 note that enabling "full-screen" is required to see the bug, as I've found out later in this conversation.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

If it's desired, I can try to bisect the commit from which it started to behave this way.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Refresh checkbox?

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

@Pentarctagon sorry, typo. "Full-screen" checkbox.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Ah, right, that makes more sense :P

And yeah, a bisect would help, unless anyone has an idea where a redraw call would need to be added to fix this issue.

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

I re-tested with full-screen (technically borderless window) option in both Windows and Linux, 1.14.7, 1.14.8+dev, and 1.15.1+dev, and couldn't replicate this, unfortunately.

Yes please, it would be helpful if you can find the commit that broke this for you since it looks like no-one else has been able to replicate the symptoms yet.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

Ah, nevermind about bisecting I guess.. It behaves this way in 1.14.7 already. IDK how far away should I dig to find it.. I'll try 1.14.0 or something like that out of curiosity though.

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Was it a long time since you last played successfully? It really does sound like it's peculiar to your system. BTW, what graphics drivers are you using? The driver issue I saw before some time ago, which had this very same symptom (and all the time, just like this issue) was with proprietary NVIDIA drivers (nouveau was fine, I think).

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

@Wedge009 the bug apparently only happens when using wesnoth-s built-in "fullscreen" mode. So I normally never observe it as I don't play wesnoth fullscreened. And even if I'do, it'd be the WM-s fullscreen mode, which doesn't have the bug.

The reason I saw the bug now is that I tested on a "clean" configuration, where fullscreen is enabled by default.

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Then it may well go back as far as 1.12 or even earlier.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

(Oh sorry, forgot to add: I have an Intel graphics card. So that's one exact possible driver.)

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Hmm, I just tried it on a Skylake-based laptop (Linux) and couldn't encounter this issue. :/

@jostephd jostephd changed the title 1.15.1 switching away from wesnoth and back makes graphics buggy 1.15.1 switching away from full-screen wesnoth and back makes graphics buggy Sep 15, 2019

@jostephd

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

  • switch to another application

  • switch back to wesnoth

How exactly do you switch to another application? There are bugs (such as #3255) that only happen when I switch virtual desktop but not when I Alt+Tab staying within the virtual desktop.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

Oh indeed! I never thought it's important, but apparently it is.

I do switch to a different virtual desktop and back.

Just checked: if I switch within same virtual desktop, the bug doesn't appear.

@vgaming

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

Furthermore, if I press the key combination to switch between windows within same virtual desktop (like Alt+Tab, but Super+Tab on my system), the screen is refreshed and the buggy graphics gets temporarily fixed. Otherwise, I had to hover all tiles with my mouse until they all refresh.

@Wedge009 Wedge009 changed the title 1.15.1 switching away from full-screen wesnoth and back makes graphics buggy 1.15.1 Switching virtual desktops with full-screen wesnoth causes graphics issues Sep 16, 2019

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Interesting, that helps explain why I couldn't see anything wrong, I don't appear to have issues with virtual desktop switching, at least not with Wesnoth. There is #2880 but that report is a full crash rather than just graphical problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.