Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [filter_weapon] don't match in [filter_student/opponent/defender/attacker] in weapon like abilities #4389

Open
newfrenchy83 opened this issue Sep 26, 2019 · 8 comments · May be fixed by #4481

Comments

@newfrenchy83
Copy link
Contributor

commented Sep 26, 2019

excuse me, but i forget what for the big mofifications, i must post issue before to put a PR with the solution. When i created weapon like abilities for emulate the specials weapons, i used [filter_weapon/filter_second_weapon] already used in leadership and resistance abilities and i forgeted to create a filter_weapon child o filter_(student/opponent etc..). For emulation will be perfect, it must change that.

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2019

@CelticMinstrel ,@gfgtdf or @jostephd please look this issue and the PR #4435, what it could be merged BEFORE béta version.

@jostephd jostephd added this to the pre-1.16.0 string freeze milestone Oct 12, 2019
@jostephd

This comment has been minimized.

Copy link
Member

commented Oct 16, 2019

@newfrenchy83 Does the wiki correctly document the behavior of master as it is today, before #4435?

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2019

@jostephd [filter_(second)_weapon] in #4435 are inactive if a weapon tags[filter_student/opponent/attacker/defender] is put in abilitie like weapon. It must mark that like deprecated in wiki https://wiki.wesnoth.org/AbilitiesWML#Extra_tags_and_keys_used_by_weapon_special_abilities

@jostephd

This comment has been minimized.

Copy link
Member

commented Oct 17, 2019

@newfrenchy83 I know that the wiki would need to be updated when #4435 or its replacement #4481 are merged, but that is not what I am asking about. I was asking you whether the wiki as it is today accurately documents the behavior of master as it is today. Does it?

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2019

i think what yes, except what [filter_student] not documented, else yes

@jostephd

This comment has been minimized.

Copy link
Member

commented Oct 18, 2019

Let's document [filter_student], then. Would it go in this section or in this one? What version was it first released in?

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2019

It go in https://wiki.wesnoth.org/AbilitiesWML#Extra_tags_and_keys_used_by_weapon_special_abilities because don't exsit in true weapon special but replace abilitie filter_self.
this filter has be commited 15 dec 2018 in ae4af30

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2019

#4481 is complete now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.