Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Damage calculations dialog should show "×2 (charge)" for the defender too #4408
I just installed the game through Steam recently. Happened even before I installed any addons. I am not sure where I can find the modifications I have applied. Hope these info helps. Should I uninstall all addons and try again?
The Battle for Wesnoth version 1.14.9 (9eba78f-Modified)
Data dir: D:\Program Files (x86)\Steam\steamapps\common\wesnoth
JPG screenshots: yes
@YellowKingValley, in the future, please share not only your conclusions but also the observations you based those conclusions on.
I will add that there is a bug in that dialog: "×2 (charge)" should be shown in the defender side of the dialog as well. However, that bug is already fixed in master:
And for reference, that screenshot is Horseman v. strong Thug at night.
I think what's needed here is basically to port the changes to attack_predictions::set_data, and then to port those "add a parameter" changes until it compiles. It might be easier to do it the other way, to backport the entire patch except for the changelog and unit::ability_affects_weapon changes.