Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint warnings #4494

Open
jostephd opened this issue Oct 20, 2019 · 2 comments

Comments

@jostephd
Copy link
Member

@jostephd jostephd commented Oct 20, 2019

Game and System Information

  • What version of the game are you running?
    1.15.1+dev

Describe the bug

make -C data/tools lint has many warnings

Expected behavior

make -C data/tools lint has no warnings

Additional context

This step is part of the release checklist, https://wiki.wesnoth.org/ReleasingWesnoth#General_maintenance, so it shouldn't output any warnings. Or alternatively, the release process should documented which warnings can be ignored.

stevecotton added a commit that referenced this issue Nov 2, 2019
There's one bugfix in this, an "id=Dela" that needed to include her surname.
@stevecotton

This comment has been minimized.

Copy link
Contributor

@stevecotton stevecotton commented Nov 2, 2019

Some of the warnings are already in other issues:

  • #4382 for ANL's sides
  • #4379 for defense caps and "missing forest=-70"
  • #4538 for "unknown 'memoirs_elves_use_orcish_weapons'"
  • #4380 for the [lua] tags in LoW S09

Stuff that's not in other issues:

  • lots of warnings and missing icons in DiD
  • wmllint will complain about ids used in events or objectives before the corresponding [side] tags
  • wmllint complains [side] without type attribute if the type is inside a macro (affects LoW and SotA)
  • warnings about "fog in map file" for some multiplayer maps

False positives / definite wmllint bugs:

"core/help.cfg", several "should not have translation mark" false positives
"core/units/humans/Loyalist_Royal_Guard.cfg", line 2: unit Royal Guard has superfluous {NOTE_*}
"core/units/humans/Loyalist_Swordsman.cfg", line 2: unit Swordsman has superfluous {NOTE_*}
"Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg", line 159: side number 1 is out of sequence (4 expected)
"Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg", line 239: side number 1 is out of sequence (4 expected)
"Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg", line 217: unknown 'Stalrag' referred to by id
"Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg", line 243: unknown 'Ro'Arthian' referred to by id
"Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg", line 268: unknown 'Ro'Sothian' referred to by id
"Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg", line 158: unknown 'Krash' referred to by id
"Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg", line 270: unknown speaker 'Rakshas' of [message]
"Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg", line 460: unknown speaker 'Krash' of [message]
"Northern_Rebirth/scenarios/12a_Get_the_Gold.cfg", line 281: unknown 'Krash' referred to by id
"Northern_Rebirth/scenarios/12a_Get_the_Gold.cfg", line 313: unknown 'Eryssa' referred to by id
"Northern_Rebirth/scenarios/13a_Showdown.cfg", line 388: unknown 'Krash' referred to by id
"Northern_Rebirth/scenarios/13a_Showdown.cfg", line 394: unknown 'Ro'Arthian' referred to by id
"Northern_Rebirth/scenarios/13a_Showdown.cfg", line 471: unknown 'Ro'Sothian' referred to by id
"Northern_Rebirth/scenarios/13a_Showdown.cfg", line 603: unknown 'Sisal' referred to by id
"Northern_Rebirth/scenarios/13a_Showdown.cfg", line 799: unknown 'Rakshas' referred to by id
"Sceptre_of_Fire/scenarios/3_Searching_for_the_Runecrafter.cfg", line 101: unknown 'Krawg' referred to by id
"Sceptre_of_Fire/scenarios/3_Searching_for_the_Runecrafter.cfg", line 115: unknown 'Thursagan' referred to by id
"Sceptre_of_Fire/scenarios/6_Towards_the_Caves.cfg", line 207: unknown 'Krawg' referred to by id
"Sceptre_of_Fire/scenarios/6_Towards_the_Caves.cfg", line 216: unknown 'Thursagan' referred to by id
"Sceptre_of_Fire/scenarios/8_The_Dragon.cfg", line 130: unknown 'Thursagan' referred to by id
"Secrets_of_the_Ancients/scenarios/22_Epilogue.cfg", line 26: [have_unit] not permitted within [part] tag
"The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg", line 548: unknown 'Mal M'Brin"' referred to by id - this and the next are wmllint parsing the line incorrectly
"The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg", line 548: unknown '"Mal Tera' referred to by id
"Two_Brothers/scenarios/02_The_Chase.cfg", line 431: unknown 'ca_muff_toras_move' referred to by id - wmllint doesn't support [candidate_action]
"Under_the_Burning_Suns/_main.cfg", line 212: campaign requires an ID attribute but has none - wmllint bug, the campaign does have an ID

Might be campaign bugs:

"Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg", line 482: unknown 'hidden_advisor' referred to by id
"Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg", line 486: unknown speaker 'hidden_advisor' of [message]
"Heir_To_The_Throne/scenarios/13_The_Dwarven_Doors.cfg", line 374: unknown 'Simyr' referred to by id
"Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg", line 69: inserting "image=wesnoth-icon.png"
"Heir_To_The_Throne/scenarios/23_Test_of_the_Clans.cfg", line 30: text needs translation mark
"Heir_To_The_Throne/utils/httt_utils.cfg", line 697: unit declaration without side attribute
"Heir_To_The_Throne/utils/httt_utils.cfg", line 712: unit declaration without side attribute
"Heir_To_The_Throne/utils/httt_utils.cfg", line 727: unit declaration without side attribute
"Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg", line 117: unknown 'Anduilas' referred to by id
"Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg", line 120: unknown 'Arkildur' referred to by id
"Northern_Rebirth/scenarios/05b_Compelled.cfg", line 125: custom ellipse ellipse/unprivileged may need to be updated
"Northern_Rebirth/scenarios/05b_Compelled.cfg", line 139: custom ellipse  may need to be updated
"Secrets_of_the_Ancients/scenarios/06_Following_the_Shadow.cfg", line 26: unknown 'Bone Captain' referred to by id
"Secrets_of_the_Ancients/scenarios/06_Following_the_Shadow.cfg", line 225: unknown speaker 'Bone Captain' of [message]
"Secrets_of_the_Ancients/scenarios/22_Epilogue.cfg", line 27: unknown 'Vendraxis' referred to by id
"Secrets_of_the_Ancients/utils/zombie-utils.cfg", line 42: list should not have a translation mark
"Secrets_of_the_Ancients/utils/zombie-utils.cfg", line 63: list should not have a translation mark
"Secrets_of_the_Ancients/utils/zombie-utils.cfg", line 350: inserting "image=wesnoth-icon.png"
"Son_Of_The_Black_Eye/scenarios/03_Toward_Mountains_of_Haag.cfg", line 43: unknown 'Grüü' referred to by id
"The_Rise_Of_Wesnoth/scenarios/12_A_Final_Spring.cfg", line 301: unknown 'Lord Typhon' referred to by id
"The_Rise_Of_Wesnoth/scenarios/20_Return_of_the_Fleet.cfg", line 188: unknown 'Lady Jessene' referred to by id
"The_South_Guard/_main.cfg", line 21: " + <span color should not have a translation mark
"The_South_Guard/scenarios/01_Born_to_the_Banner.cfg", line 111: unknown 'Sir Gerrick' referred to by id
"The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg", line 231: unknown 'Minister Hylas' referred to by id
"The_South_Guard/scenarios/06b_The_Long_March.cfg", line 467: unknown 'Urza Afalas' referred to by id
"The_South_Guard/scenarios/08b_The_Tides_of_War.cfg", line 648: unknown speaker 'Minister Romand' of [message]
"Under_the_Burning_Suns/scenarios/01_The_Morning_After.cfg", line 130: unknown 'Xanthos' referred to by id
"Under_the_Burning_Suns/scenarios/02_Across_the_Harsh_Sands.cfg", line 207: unknown 'Thorn' referred to by id
"Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg", line 215: unknown 'Possessed Garak' referred to by id
"Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg", line 332: unknown 'Cloaked Figure' referred to by id
"Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg", line 403: unknown 'Sergeant Durstrag' referred to by id
"Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg", line 403: unknown 'Esanoo' referred to by id
"Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg", line 333: unknown 'Tanstafaal' referred to by id
"Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg", line 333: unknown 'Eloh' referred to by id
"Under_the_Burning_Suns/scenarios/12_The_Final_Confrontation.cfg", line 261: unknown 'Eloh' referred to by id
"Under_the_Burning_Suns/scenarios/12_The_Final_Confrontation.cfg", line 270: unknown 'Yechnagoth' referred to by id
"The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg", line 78: Poacher (archer) doesn't match the recruitment pattern (fighter, scout, scout) for its side
"The_South_Guard/scenarios/06a_Into_the_Depths.cfg", line 89: At EASY, Bone Shooter (archer) doesn't match the EASY recruitment pattern (fighter, scout, fighter) for its side
"The_South_Guard/scenarios/06a_Into_the_Depths.cfg", line 92: At NORMAL, Bone Shooter (archer) doesn't match the NORMAL recruitment pattern (fighter, scout, fighter) for its side
"The_South_Guard/scenarios/06a_Into_the_Depths.cfg", line 92: At NORMAL, Dark Adept (archer) doesn't match the NORMAL recruitment pattern (fighter, scout, fighter) for its side
"The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg", line 102: At EASY, Vampire Bat (scout) doesn't match the recruitment pattern (fighter) for its side
"The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg", line 105: At NORMAL, Blood Bat (scout) doesn't match the recruitment pattern (fighter) for its side
"The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg", line 108: At HARD, Blood Bat (scout) doesn't match the recruitment pattern (fighter) for its side
"The_South_Guard/scenarios/08b_The_Tides_of_War.cfg", line 98: no archer units recruitable.
"The_South_Guard/scenarios/08b_The_Tides_of_War.cfg", line 98: no archer units recruitable.
"The_South_Guard/scenarios/08b_The_Tides_of_War.cfg", line 98: no mixed fighter units recruitable.
"Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg", line 84: no archer units recruitable.
@CelticMinstrel

This comment has been minimized.

Copy link
Member

@CelticMinstrel CelticMinstrel commented Nov 3, 2019

wmllint complains [side] without type attribute if the type is inside a macro (affects LoW and SotA)

Pretty sure this is what the recognize and related wmllint directives are for. I don't think there's any other way to solve it (short of making wmllint run the preprocessor).

Elvish-Hunter added a commit that referenced this issue Nov 10, 2019
Fixes some of the warnings listed in #4494
Elvish-Hunter added a commit that referenced this issue Nov 12, 2019
This fixed part of the warning listed in #4494 and part of #4381
Elvish-Hunter added a commit that referenced this issue Nov 13, 2019
Fixes the warnings for Swordsman and Royal Guard units listed in #4494
Elvish-Hunter added a commit that referenced this issue Nov 13, 2019
Fixes the TB warning listed in #4494
Elvish-Hunter added a commit that referenced this issue Nov 15, 2019
Elvish-Hunter added a commit that referenced this issue Nov 15, 2019
…r] tag inside

Fixes a wmllint warning in TSG, which is listed in #4494
Elvish-Hunter added a commit that referenced this issue Nov 16, 2019
Fixes also part of #4381
Elvish-Hunter added a commit that referenced this issue Nov 16, 2019
Fixes a warning listed in #4494 as well as a few more 'unrecognized character' warnings not listed there; it's also part of #4381.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.