Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [filter] to [advancement] #4495

Open
gfgtdf opened this issue Oct 20, 2019 · 0 comments
Labels

Comments

@gfgtdf
Copy link
Contributor

@gfgtdf gfgtdf commented Oct 20, 2019

I think it might be useful to have a [filter] tag in [advancement], so that the [advancement] is only available if the unit matches the [filter], this is effectively more flexible than the current require_amla/exclude_amla: one could just have other advancements keep track of them via varibale-set effect, and then us the filter to have for example a 'available of the unit has already exactly two of the following advancements' filter.

Of course this can already be implemented via pre_advance events and setting the list fo possible amlas in pre_advance events, so not sure whether its really needed, still it think it might be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.