Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Editor tools from actual hot-keys #4509

Open
Wedge009 opened this issue Oct 22, 2019 · 3 comments

Comments

@Wedge009
Copy link
Member

@Wedge009 Wedge009 commented Oct 22, 2019

As the title says. I'm looking at (as a sample):

{ HOTKEY_EDITOR_TOOL_PAINT, "editor-tool-paint", N_("Paint Tool"), false, scope_editor, HKCAT_TOOLS, N_("Use left/right mouse button to draw fore-/background terrain. Hold Shift to paint base layer only. Ctrl+click to sample terrain under cursor.") },
{ HOTKEY_EDITOR_TOOL_FILL, "editor-tool-fill", N_("Fill Tool"), false, scope_editor, HKCAT_TOOLS, N_("Use left/right mouse button to draw fore-/background terrain. Hold Shift to paint base layer only. Ctrl+click to sample terrain under cursor.") },
{ HOTKEY_EDITOR_TOOL_SELECT, "editor-tool-select", N_("Selection Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button selects or deselects with Ctrl, right brings up a context menu. Hold Shift for magic-wand selection of tiles with same terrain.") },
{ HOTKEY_EDITOR_TOOL_STARTING_POSITION, "editor-tool-starting-position", N_("Starting Positions Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button displays player selection, right clears. Number keys scroll to the starting position, alt+number sets respective starting position under cursor, delete clears.") },
{ HOTKEY_EDITOR_TOOL_LABEL, "editor-tool-label", N_("Label Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button sets or drags a label, right clears.") },
{ HOTKEY_EDITOR_TOOL_UNIT, "editor-tool-unit", N_("Unit Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button sets a new unit or moves a unit via drag and drop, right brings up a context menu. Needs a defined side.") },
{ HOTKEY_EDITOR_TOOL_ITEM, "editor-tool-item", N_("Item Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button sets a new item or moves it via drag and drop, right clears. Not implemented yet.") },
{ HOTKEY_EDITOR_TOOL_SOUNDSOURCE, "editor-tool-soundsource", N_("Sound Source Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button sets or drags a sound source, right clears. Not implemented yet.") },
{ HOTKEY_EDITOR_TOOL_VILLAGE, "editor-tool-village", N_("Village Tool"), false, scope_editor, HKCAT_TOOLS, N_("Left mouse button sets the village ownership to the current side, right clears. Needs a defined side.") },

These are all Editor hot-keys and they have tool-tip text - last parameter. Most of the others do not have anything for the tool-tip text - why is this? Are they not implemented (displayed) outside of an Editor context?

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

@ProditorMagnus ProditorMagnus commented Oct 22, 2019

Those are not normal hotkeys, they provide combined functionality which only exists as key.

@Wedge009

This comment has been minimized.

Copy link
Member Author

@Wedge009 Wedge009 commented Oct 22, 2019

Oh right. So they should probably be split out into different classes if they have different meanings.

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

@ProditorMagnus ProditorMagnus commented Oct 22, 2019

It would make sense to split if that would add way to get actual hotkey for cases where it is possible change hotkeys.

@Wedge009 Wedge009 changed the title Why are hot-key tool-tips only used for Editor-based keys? Separate Editor tools from actual hot-keys Oct 22, 2019
@Wedge009 Wedge009 added Enhancement Input and removed Help Question labels Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.