Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wesnoth does not render well with SDL 2.0.10 #4510

Open
Wedge009 opened this issue Oct 22, 2019 · 8 comments

Comments

@Wedge009
Copy link
Member

@Wedge009 Wedge009 commented Oct 22, 2019

Game and System Information

master and 1.14 on Windows 7 and Linux with SDL 2.0.10.

Describe the bug

Aside from the default batched renders introduced with SDL 2.0.10 (see #4237 and #4245), it looks like Wesnoth is still using SDL in a way that may not be intended by SDL developers and so we have graphical artefacts like #2742 returning.

To reproduce

There are many ways to find errors, including the aforementioned #2742, but scrolling seems to be a good way to achieve this. One way is:

  1. Start Wesnoth
  2. Open Help
  3. Open a unit entry and scroll up and down
  4. Result in screenshot below - note the un-redrawn text and picture elements accumulated above and below the scroll area.

Expected behaviour

Normal rendering behaviour as it stands with SDL 2.0.9 or earlier.

Screenshots

badrender

@Wedge009

This comment has been minimized.

Copy link
Member Author

@Wedge009 Wedge009 commented Oct 23, 2019

@sevu Your confirmation is on Linux?

@Wedge009

This comment has been minimized.

Copy link
Member Author

@Wedge009 Wedge009 commented Oct 24, 2019

I confirm with Linux.

@sevu

This comment has been minimized.

Copy link
Member

@sevu sevu commented Oct 24, 2019

yes

@Wedge009

This comment has been minimized.

Copy link
Member Author

@Wedge009 Wedge009 commented Oct 26, 2019

Another example is to move around the map while in game, and note the white mini-map rectangle outline leaving a trail behind.

@jostephd

This comment has been minimized.

Copy link
Member

@jostephd jostephd commented Oct 26, 2019

As in #3255?

@Wedge009

This comment has been minimized.

Copy link
Member Author

@Wedge009 Wedge009 commented Oct 26, 2019

Yes, but as discussed previously, that case appears to be related to virtual desktops whereas this one is most definitely from SDL 2.0.10 version specifically. Same symptom, but apparently different cause.

@shikadiqueen

This comment has been minimized.

Copy link
Member

@shikadiqueen shikadiqueen commented Oct 27, 2019

Why is this marked Upstream even though we have no real confirmation yet as to whether it's our bug or theirs?

@Wedge009

This comment has been minimized.

Copy link
Member Author

@Wedge009 Wedge009 commented Oct 27, 2019

Issues that are or involve issues with libraries, tools, or platforms Wesnoth uses.

Wesnoth code may still be ultimately responsible but it's clearly affected by the different library versions too. Feel free to remove the label if you deem it necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.