Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Game and System Information
Linux, current git master at 1a67d53
Describe the bug
The engine for schema validation strips the underscore from translatable strings before checking the value with the schema, which means that the schema can't enforce translatability of strings.
The schema declares that t_strings should optionally start with an underscore; this bug is hidden because the schema says the underscore is only optional:
I want to change that regexp is to only allowing (empty without underscore) or (value starting with underscore),
even though there is an underscore on that line (and the other lines that are complained about):
This is probably not caused by anything in the schema; it's likely due to the WML parser converting the raw WML into actual typed data by the time the schema sees it. I think the idea of trying to match translatable strings via regex is probably flawed to begin with, given that. But I'm not sure if there's really a better way, other than maybe accepting a
Another thing to note is that not all strings that could be translatable are marked as such. For example, I believe most of the test scenarios do not mark their strings translatable.