Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of $unit.overlays in ANL, DiD and SotA #4550

Closed
stevecotton opened this issue Nov 4, 2019 · 5 comments
Labels
Milestone

Comments

@stevecotton
Copy link
Contributor

@stevecotton stevecotton commented Nov 4, 2019

As of PR #4211, setting [unit]overlays= works, but the [unit]overlays attribute will always be empty if WML tries to read it. This means the following three uses are now broken:

@stevecotton stevecotton added this to the 1.16.0 milestone Nov 4, 2019
@nemaara

This comment has been minimized.

Copy link
Contributor

@nemaara nemaara commented Nov 4, 2019

I already removed that here 79d97a1.

@stevecotton

This comment has been minimized.

Copy link
Contributor Author

@stevecotton stevecotton commented Nov 4, 2019

Removed the leftover DiD code in 80b03f1

@Wedge009 Wedge009 added the Bug label Nov 5, 2019
@sevu

This comment has been minimized.

Copy link
Member

@sevu sevu commented Nov 9, 2019

Will change the ANL code

@sigurdfdragon

This comment has been minimized.

Copy link
Contributor

@sigurdfdragon sigurdfdragon commented Nov 9, 2019

Removed from SotA in f55704c

@sevu

This comment has been minimized.

Copy link
Member

@sevu sevu commented Nov 14, 2019

5ee5920 changes the ANL part.

@sevu sevu closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.