Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SotBE S14, Lua error after winning the scenario #4556

Open
Konrad22 opened this issue Nov 8, 2019 · 12 comments

Comments

@Konrad22
Copy link
Contributor

@Konrad22 Konrad22 commented Nov 8, 2019

Game and System Information

  • What version of the game are you running?
    1.15.2

  • Where did you download it from? (Steam, Mac App Store, our website, built from source, etc.)
    Sourceforge

  • What OS are you running?
    Windows 10

Describe the bug

I defeated the last enemy leader (scenario objectives are to defeat all enemy leaders) and then the lua error appeared.

To Reproduce

Steps to reproduce the behavior:

  1. Start the scenario 'Back Home'.
  2. Wait for Grüü to appear (turn 7).
  3. Defeat all enemy leaders, e.g. by using debug mode.

Expected behavior

No Lua error appears. Just the normal grey out because the scenario is over.

Screenshots

grafik

Savefiles

SotBE-Back Home-Auto-Save7.gz

@gfgtdf

This comment has been minimized.

Copy link
Contributor

@gfgtdf gfgtdf commented Nov 8, 2019

This is probably caused by my recent midufy_unit rrfactir, but I won't be at home until Saturday in 8 days

@CelticMinstrel

This comment has been minimized.

Copy link
Member

@CelticMinstrel CelticMinstrel commented Nov 16, 2019

Does that fix it?

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

@Konrad22 Konrad22 commented Nov 18, 2019

I have no idea, since I don't know how to build wesnoth. I can check at earliest when 1.15.3 is out.
But I'm sure there are other people who can test this.

@gfgtdf

This comment has been minimized.

Copy link
Contributor

@gfgtdf gfgtdf commented Nov 18, 2019

I have no idea, since I don't know how to build wesnoth

this is a change to the lua files, you onyl need to replace those lua files. no building involved

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

@Konrad22 Konrad22 commented Nov 18, 2019

FTR, the content of those lua files was different from the content of 'my' lua files ever before the (so far untested) fix.

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

@Konrad22 Konrad22 commented Nov 18, 2019

I'm getting this instead.
grafik

Did you do the refactor before 1.15.2 was released?

@gfgtdf

This comment has been minimized.

Copy link
Contributor

@gfgtdf gfgtdf commented Nov 18, 2019

I'm getting this instead.

oh yes this is another error, this one does require rebuilding

@soliton-

This comment has been minimized.

Copy link
Member

@soliton- soliton- commented Nov 20, 2019

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

@Konrad22 Konrad22 commented Nov 21, 2019

To be honest I have no idea what I'm supposed to do with that. Downloading this and the starting that wesnoth.exe throws an assertion error, so I guess that's not what I'm expected to do.

@soliton-

This comment has been minimized.

Copy link
Member

@soliton- soliton- commented Nov 21, 2019

Put the files from the zip into a git checkout of wesnoth or wherever you tested the updated lua files earlier.

@Konrad22

This comment has been minimized.

Copy link
Contributor Author

@Konrad22 Konrad22 commented Nov 21, 2019

I just replaced the relevant lua file. I'm not sure if this would work with this stuff as well.

@gfgtdf

This comment has been minimized.

Copy link
Contributor

@gfgtdf gfgtdf commented Nov 22, 2019

Honestly I think we know well where this bug came from and I for my part am fine with closing this one without further testing assuming it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.