Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP


Fixup check_victory (for mattsc) #142

wants to merge 0 commits into from

1 participant


*** Please don't merge this, this is in a testing and review stage. ***

This branch is intended to address concerns raised by mattsc on irc. See
and the day before for discussion.

The proposed solution is to introduce a field of [side] "fight_on_without_leader",
and refactor check_victory so that any side with this field true and a unit alive
is not considered "defeated". We use this instead of no_leader in places where
that was being used (erroneously?)

@cbeck88 cbeck88 closed this
@cbeck88 cbeck88 deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Sorry, commit information is not available for this pull request.

Something went wrong with that request. Please try again.