New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filters using this_unit in [hides] #2033

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@gfgtdf
Contributor

gfgtdf commented Sep 22, 2017

args.loc is the location we use for 'filter as if the unit woudl be there', still the unit is curently at args.u.get_location() so to make scoped_xy_unit find the unit we have to give args.u.get_location()

fix filters using this_unit in [hides]
args.loc is the location we use for 'filter as if the unit woudl be there', still the unit is curently at args.u.get_location() so to make scoped_xy_unit  find the unit we have to give args.u.get_location()
@Vultraz

This comment has been minimized.

Show comment
Hide comment
@Vultraz

Vultraz Oct 16, 2017

Member

Status on this?

Member

Vultraz commented Oct 16, 2017

Status on this?

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Oct 16, 2017

Member

Somehow forgot about this. Looks good to me.

Member

CelticMinstrel commented Oct 16, 2017

Somehow forgot about this. Looks good to me.

@Vultraz Vultraz merged commit f5911b6 into master Oct 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Vultraz Vultraz deleted the gfgtdf-patch_filter_this_unit branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment