New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach wmlscope to ignore frame durations. Fixes #2045 #2053

Merged
merged 3 commits into from Oct 15, 2017

Conversation

Projects
None yet
2 participants
@AI0867
Member

AI0867 commented Sep 29, 2017

No description provided.

Show outdated Hide outdated data/tools/wesnoth/wmltools3.py
Show outdated Hide outdated data/tools/wesnoth/wmltools3.py
Show outdated Hide outdated data/tools/wesnoth/wmltools3.py

AI0867 added some commits Oct 2, 2017

Require period before extension, make previous chargroup non-greedy
This reduced the number of false positives by filtering out things like Grogg, editor-map, png and water/wav

@AI0867 AI0867 merged commit cd4e255 into wesnoth:master Oct 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AI0867 AI0867 deleted the AI0867:wmlscope-durations branch Oct 15, 2017

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 6, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 6, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275
Former-commit-id: 6894f399e6344ecc8b4ddd2fafeaf465a47ab1ca [formerly 086754cd6a7c8f9a3f6fdc9fd5f6e23c106d7418]
Former-commit-id: 1a87a38c294f263cb2a938ce9681edc6db608549

fendrin pushed a commit to fendrin/wesnoth-src that referenced this pull request Nov 6, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275
Former-commit-id: 6894f399e6344ecc8b4ddd2fafeaf465a47ab1ca [formerly 086754cd6a7c8f9a3f6fdc9fd5f6e23c106d7418]
Former-commit-id: 1a87a38c294f263cb2a938ce9681edc6db608549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment