New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when unable to find closest enemy. #2072

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@Jozrael
Contributor

Jozrael commented Oct 2, 2017

Sanity check - is it better to vet both levels? [if target && if target.x] ?

Or not necessary?

@mattsc

This comment has been minimized.

Show comment
Hide comment
@mattsc

mattsc Oct 2, 2017

Member

Yeah, I thought about that too, but there is really no way for target not to be nil and target.x and target.y not to be set. So it really isn't necessary.

I'll wait a couple hours to see if somebody disagrees and then I'll merge this.

Member

mattsc commented Oct 2, 2017

Yeah, I thought about that too, but there is really no way for target not to be nil and target.x and target.y not to be set. So it really isn't necessary.

I'll wait a couple hours to see if somebody disagrees and then I'll merge this.

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Oct 2, 2017

Contributor

I'll wait a couple hours to see if somebody disagrees and then I'll merge this.

Since people live in different timezomes it's usually better to wait a whole 24 hours, but yes looks good to me (not that i know that code).

Contributor

gfgtdf commented Oct 2, 2017

I'll wait a couple hours to see if somebody disagrees and then I'll merge this.

Since people live in different timezomes it's usually better to wait a whole 24 hours, but yes looks good to me (not that i know that code).

@mattsc

This comment has been minimized.

Show comment
Hide comment
@mattsc

mattsc Oct 2, 2017

Member

Since people live in different timezomes it's usually better to wait a whole 24 hours

True. I really don't see any potential problem here that's why I said a couple hours, but waiting till tomorrow makes more sense.

Member

mattsc commented Oct 2, 2017

Since people live in different timezomes it's usually better to wait a whole 24 hours

True. I really don't see any potential problem here that's why I said a couple hours, but waiting till tomorrow makes more sense.

@mattsc mattsc merged commit c2ca211 into wesnoth:master Oct 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment