New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terrain.cfg: Fix grammar in Rockbound Cave #2082

Merged
merged 3 commits into from Oct 14, 2017

Conversation

Projects
None yet
3 participants
@jostephd
Contributor

jostephd commented Oct 7, 2017

Remove "who", add full stop.

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Oct 8, 2017

Member

This looks good, but if you'd like to also add a few "the" in there it would be nice (particularly "the main settlers" but there was at least one other place where I thought an article would make it sound better).

Member

CelticMinstrel commented Oct 8, 2017

This looks good, but if you'd like to also add a few "the" in there it would be nice (particularly "the main settlers" but there was at least one other place where I thought an article would make it sound better).

@Ja-MiT

This comment has been minimized.

Show comment
Hide comment
@Ja-MiT

Ja-MiT Oct 8, 2017

Contributor

Another place: "reduces the efficiency of most units".

Contributor

Ja-MiT commented Oct 8, 2017

Another place: "reduces the efficiency of most units".

@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd

jostephd Oct 8, 2017

Contributor

@CelticMinstrel @Ja-MiT Thanks for the review; added both. What about "formed by the action of water and wind", is that correct? Should the "the" be removed, or another added?

Contributor

jostephd commented Oct 8, 2017

@CelticMinstrel @Ja-MiT Thanks for the review; added both. What about "formed by the action of water and wind", is that correct? Should the "the" be removed, or another added?

@Ja-MiT

This comment has been minimized.

Show comment
Hide comment
@Ja-MiT

Ja-MiT Oct 8, 2017

Contributor

I think that part is fine as it is. While it would be correct to say "the water and wind", you'd lose some poetic feel to the description.

The part that still strikes me as odd is "the full advantage", where I would drop "the". However, that might be just personal style.

Contributor

Ja-MiT commented Oct 8, 2017

I think that part is fine as it is. While it would be correct to say "the water and wind", you'd lose some poetic feel to the description.

The part that still strikes me as odd is "the full advantage", where I would drop "the". However, that might be just personal style.

@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd

jostephd Oct 8, 2017

Contributor

Right, thanks. What about changing "advantage" to "capability"?

Contributor

jostephd commented Oct 8, 2017

Right, thanks. What about changing "advantage" to "capability"?

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Oct 8, 2017

Member

That phrasing seems rather awkward in general. I think it might be better to write something more like "Dwarves ... can easily navigate the terrain."

Member

CelticMinstrel commented Oct 8, 2017

That phrasing seems rather awkward in general. I think it might be better to write something more like "Dwarves ... can easily navigate the terrain."

@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd

jostephd Oct 9, 2017

Contributor

How about just deleting that sentence entirely? It repeats the preceding one.

Or, alternatively, see the commit I just added (5be5170), which makes a few more tweaks.

Contributor

jostephd commented Oct 9, 2017

How about just deleting that sentence entirely? It repeats the preceding one.

Or, alternatively, see the commit I just added (5be5170), which makes a few more tweaks.

@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd

jostephd Oct 14, 2017

Contributor

The travis error seems to be a false positive. Is there anything else I need to do to move this forward?

Contributor

jostephd commented Oct 14, 2017

The travis error seems to be a false positive. Is there anything else I need to do to move this forward?

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Oct 14, 2017

Member

Nothing whatsoever.

Member

CelticMinstrel commented Oct 14, 2017

Nothing whatsoever.

@CelticMinstrel CelticMinstrel merged commit b83a3b3 into wesnoth:master Oct 14, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd

jostephd Oct 14, 2017

Contributor

Cheers!

Contributor

jostephd commented Oct 14, 2017

Cheers!

GregoryLundberg added a commit that referenced this pull request Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment