New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP- don't commit!] - Giant Scorpion unit images #2266

Merged
merged 8 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@doofus-01
Member

doofus-01 commented Dec 3, 2017

The goal of this PR is to get complete SE facing animations for Giant Scorpion, as well as a replacement for the portrait.
For now, we just have defense animation and completely flat (unusable, WIP) portrait.

@Vultraz Vultraz added this to the 1.14.0 milestone Dec 3, 2017

doofus-01 added some commits Dec 4, 2017

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Dec 4, 2017

Member

There are serviceable (I think) animations now for both of the attacks and for the defense. Some clean-up is required, but I'll assume they are basically OK unless I hear otherwise. The portrait, well, I hope to get to that next week.

Member

doofus-01 commented Dec 4, 2017

There are serviceable (I think) animations now for both of the attacks and for the defense. Some clean-up is required, but I'll assume they are basically OK unless I hear otherwise. The portrait, well, I hope to get to that next week.

doofus-01 added some commits Dec 9, 2017

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Dec 10, 2017

Member

I've added a north-facing base, I'll see if anyone has a comment before I move on to any animation frames for it. There's a screenshot on the forums:
https://forums.wesnoth.org/viewtopic.php?f=9&t=37000&p=620714#p620714

Member

doofus-01 commented Dec 10, 2017

I've added a north-facing base, I'll see if anyone has a comment before I move on to any animation frames for it. There's a screenshot on the forums:
https://forums.wesnoth.org/viewtopic.php?f=9&t=37000&p=620714#p620714

doofus-01 added some commits Dec 11, 2017

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Dec 11, 2017

Member

There are now SE-facing defend & attack frames, NE-facing standing & defend frames, and a shaded portrait. Is any of it an awe-inspiring masterpiece? Well, no, but is it better than what we have so far? I really believe it is. I'll give it a week, and if no one has any objections, I'll merge.

Member

doofus-01 commented Dec 11, 2017

There are now SE-facing defend & attack frames, NE-facing standing & defend frames, and a shaded portrait. Is any of it an awe-inspiring masterpiece? Well, no, but is it better than what we have so far? I really believe it is. I'll give it a week, and if no one has any objections, I'll merge.

@doofus-01 doofus-01 requested review from Lordbob and ln-zookeeper Dec 11, 2017

@doofus-01 doofus-01 merged commit 8473e49 into wesnoth:master Dec 15, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@doofus-01 doofus-01 deleted the doofus-01:scorpion_regular branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment