Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reachmap ai turn fix #2365

Closed
wants to merge 3 commits into from
Closed

Conversation

AI0867
Copy link
Member

@AI0867 AI0867 commented Jan 12, 2018

This should address issue #2197.

@AI0867 AI0867 requested a review from gfgtdf January 12, 2018 11:33
@gfgtdf
Copy link
Contributor

gfgtdf commented Apr 28, 2018

hmm compltley missed this one, assignoing to to me for now to that i won't forget it again

@gfgtdf gfgtdf self-assigned this Apr 28, 2018
@sevu sevu added this to the 1.14.6 milestone Sep 10, 2018
@GregoryLundberg
Copy link
Contributor

@gfgtdf ping

@Pentarctagon
Copy link
Member

So should this be left as tagged for 1.14.6, or should it be moved to 1.14.7? This PR is now just over a year old.

@gfgtdf
Copy link
Contributor

gfgtdf commented Jan 13, 2019

From looking at the code this seems to change how cursors behave: not the wait cursor is shown during network human turns. If this means that you can no longer check the units reachmaps during network turns, then i don't think this is a good idea.

Also for idle sides before_human_turn() is called but after_human_turn is not, also after_human_turn might not be calles if the sides controller was changed. So in total i think this looks somwwhat incomplte to me.

In total i'd say that this needs testing and should not go into 1.14.6 unless someone has the time do to the testing.

@Vultraz Vultraz modified the milestones: 1.14.6, 1.14.7 Jan 22, 2019
@nemaara nemaara modified the milestones: 1.14.7, 1.14.8 Apr 16, 2019
@AI0867 AI0867 requested a review from sevu June 21, 2019 21:10
@nemaara nemaara modified the milestones: 1.14.9, 1.14.10 Sep 27, 2019
@Wedge009 Wedge009 added the UI User interface issues, including both back-end and front-end issues. label Nov 12, 2019
@nemaara nemaara modified the milestones: 1.14.10, 1.14.12 Feb 29, 2020
@Pentarctagon Pentarctagon removed this from the 1.14.12 milestone Aug 10, 2020
@Pentarctagon
Copy link
Member

@gfgtdf Thoughts on whether to keep this open or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants