New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiD S02: Stop when ambushed #3227

Merged
merged 1 commit into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@stevecotton
Contributor

stevecotton commented Jun 8, 2018

This happens in a village-capture event, so the unit has finished
moving for this turn in any case.

DiD S2: When ambushed by goblins, cancel any pending attack
This happens in a village-capture event, so the unit has finished
moving for this turn in any case.

@ln-zookeeper ln-zookeeper self-assigned this Jun 8, 2018

@ln-zookeeper ln-zookeeper merged commit cf6bb49 into wesnoth:1.14 Jun 8, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

ln-zookeeper added a commit that referenced this pull request Jun 8, 2018

DiD S2: When ambushed by goblins, cancel any pending attack (#3227)
This happens in a village-capture event, so the unit has finished
moving for this turn in any case.

@stevecotton stevecotton deleted the stevecotton:did_stop_when_ambushed branch Jun 9, 2018

@eyalroz

This comment has been minimized.

Show comment
Hide comment
@eyalroz

eyalroz Aug 31, 2018

Shouldn't this happen more generally? In regular gameplay, when you move and become adjacent to an amubsher unit, you stop. Why shouldn't this principle be applied whenever a previously-not-visible unit appears in a tile next to you during movement?

eyalroz commented Aug 31, 2018

Shouldn't this happen more generally? In regular gameplay, when you move and become adjacent to an amubsher unit, you stop. Why shouldn't this principle be applied whenever a previously-not-visible unit appears in a tile next to you during movement?

jostephd added a commit to jostephd/wesnoth that referenced this pull request Oct 6, 2018

DiD S2: When ambushed by goblins, cancel any pending attack (wesnoth#…
…3227)

This happens in a village-capture event, so the unit has finished
moving for this turn in any case.

jostephd pushed a commit to jostephd/wesnoth that referenced this pull request Oct 7, 2018

DiD S2: When ambushed by goblins, cancel any pending attack (wesnoth#…
…3227)

This happens in a village-capture event, so the unit has finished
moving for this turn in any case.

(cherry-picked from commit 8d055bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment