Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Automatic update checking #3464

Open
wants to merge 2 commits into
base: 1.14
from

Conversation

@hrubymar10
Copy link
Member

commented Aug 13, 2018

For SourceForge versions it would be really usefull to have update checking system.

TODO

@hrubymar10 hrubymar10 added this to the 1.14.5 milestone Aug 13, 2018

@hrubymar10 hrubymar10 self-assigned this Aug 13, 2018

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

Typo in the commit message - "backend"

@@ -210,6 +210,11 @@ game_launcher::game_launcher(const commandline_options& cmdline_opts, const char
no_music = true;
if (cmdline_opts_.nosound)
no_sound = true;
if (cmdline_opts_.noupdatecheck) {

This comment has been minimized.

Copy link
@CelticMinstrel

CelticMinstrel Aug 14, 2018

Member

I'm fairly sure this is not the right way to add this setting? If I understand correctly, putting it in preferences means it'll be stored in the preferences file. That means that running once with --no-update-check permanently disables update checking unless you edit or delete your preferences file.

This comment has been minimized.

Copy link
@hrubymar10

hrubymar10 Aug 14, 2018

Author Member

It will disable update checking until next start. There is also else statement here.

This comment has been minimized.

Copy link
@CelticMinstrel

CelticMinstrel Aug 15, 2018

Member

Thinking about it... you're actually right, because not passing the flag will reset the preference to true. That still means that it doesn't really belong in preferences. If I understand correctly, with what you've set up here, it'll be written out to preferences but ignored when reading in the prefs.

This comment has been minimized.

Copy link
@hrubymar10

hrubymar10 Aug 15, 2018

Author Member

You are right. It don't belong to preferences. I need to save variable somewhere so I decided to save information about if we will check for updates or not into preferences, because it is acessible from whole code. I think that best way is save it to preferences because in future we can add physical option into preferences dialog to forbid update checking at all. As of now the preferences dialog won't contain any checkbox or something related to update checking.

@GregoryLundberg

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2018

Maybe Windows and macOS can auto-install an updated version, but there is no reason Linux cannot, at least, tell you to start hassling your packager. Not that it matters to me because my morning routine is to roll in the overnights from Arch, and the Arch Wesnoth packager always seems to jump the gun and push as soon as we're tagged, well before the announcement.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

@GregoryLundberg My impression was that this isn't even going to be an auto-install, just a notification that there is an update.

@hrubymar10

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2018

@GregoryLundberg Yes, I don't want to create our custom implementation of auto-update system. My only target is inform users about new updates. Nothing else. It will be totally up to user if he will decide to update now or later or never.

@hrubymar10 hrubymar10 force-pushed the update_check branch from 9586dfa to 0f04f5e Aug 15, 2018

@hrubymar10 hrubymar10 force-pushed the update_check branch from ddeb9a7 to 7796799 Aug 18, 2018

@hrubymar10 hrubymar10 added the Postponed label Sep 9, 2018

@hrubymar10 hrubymar10 modified the milestones: 1.14.5, 1.14.6 Sep 9, 2018

@GregoryLundberg GregoryLundberg modified the milestones: 1.14.6, 1.16.0 Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.