Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Healing: Do heal on turn 1. #3562
i currently think it should not heal on the first turn of the the first player only, so that the scenario designer can place 'wounded' units at start, it also make somehow sense as there is side turn start but not really a side turn 'transition' for the first turn of the first player.
added a commit
this pull request
Sep 22, 2018
@gfgtdf I agree. It would be cleaner not to do healing on
The old code said "if turn > 1" and we're changing it to read "if turn > 1 or side > 1".
So if they played with turn numbers, this is a non-issue.
The only issue I could see if is they (effectively) don't have a "side 1", or they depended upon no healing occurring for any side on turn 1.
If they're playing games with turn and/or side numbering, there's not a lot we can do about it.
I imagine, in the rare case where they actually depend upon no healing at all throughout all of turn 1, well, a change log entry (which this PR is missing, BTW), should warn them. But there's not a lot we can do about that.
ETA: Well there might be problems if we allow turn 0 or turn -23, but we'd have had those problems, anyway. It would be nice if "turn" were "unsigned int" with the first turn being turn "0" and displaying as "1", but that's entirely another issue.