Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show time of day under shroud #3638

Merged
merged 1 commit into from Oct 21, 2018

Conversation

@jostephd
Copy link
Member

commented Oct 20, 2018

In the test scenario mouseover (4,19) to see the difference.

In master, the tod image and tod schedule indication in the sidebar show:

  • "dusk 4/6" outside the cave
  • "dusk 1/1" on (4,19) in master - leaking the fact that the tod schedule under the shroud consists of one timezone
  • "dusk 4/6" on (4,19) with this patch - on a shrouded hex it shows what it shows on a non-shrouded hex, regardless of the time area of the shrouded hex. Is that good or would it be better to show, say, a black image and "?/?" instead, when mouseover'ing a shrouded hex?

(tagging "bug" because showing dusk and 1/1 is definitely incorrect)

@jostephd jostephd added Bug UI labels Oct 20, 2018

@jostephd jostephd self-assigned this Oct 20, 2018

@GregoryLundberg

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2018

Looks good to me. Does this also need to go into 1.14? Sounds likely.

@jostephd

This comment has been minimized.

Copy link
Member Author

commented Oct 20, 2018

Thanks for the review, and yes, I'll backport this to 1.14.

@GregoryLundberg GregoryLundberg added this to the 1.14.6 milestone Oct 20, 2018

Don't show time of day under shroud
In the test scenario mouseover (4,19) to see the difference.

@jostephd jostephd force-pushed the jostephd:tod-under-shroud branch from 91fa163 to 23bdbae Oct 21, 2018

@jostephd jostephd merged commit 23bdbae into wesnoth:master Oct 21, 2018

0 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.