Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip Fix #3717 #3720

Open
wants to merge 2 commits into
base: master
from

Conversation

@gfgtdf
Copy link
Contributor

commented Nov 13, 2018

No description provided.

@jyrkive
Copy link
Member

left a comment

Use a custom struct to save the game versions instead of std::pair.

src/server/game.hpp Outdated Show resolved Hide resolved
src/server/game.hpp Show resolved Hide resolved

gfgtdf added some commits Nov 13, 2018

wesnothd: add game::get_player_versions()
helper function to get the minimum/mximum used client version.
don't send whiteboard data to older clients
oos was oserved when processing whiteboard data on older clients.

@gfgtdf gfgtdf force-pushed the gfgtdf:fix_3717 branch from 4bfff39 to ec0fd32 Nov 16, 2018

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

@gfgtdf Please put the issue number (#3717) in the PR description instead of the title in future.

@gfgtdf

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2018

ftr this was merged into 1.14 already, still open becasue im undecided whether i want to put it into master aswell.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Sure. My statement still stands though.

@sevu sevu added the Postponed label Jan 6, 2019

@sevu sevu added this to the 1.15.0 milestone Jan 6, 2019

@jostephd jostephd added the Fwdport label Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.