Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash after hitting enter when no units match the recruit list filter #3969

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@addaleax
Copy link
Contributor

commented Mar 5, 2019

This is essentially the same as #3476, except that it is applied to the recruit dialog rather than the recall dialog.

Fix crash after hitting enter when no units match the recruit list fi…
…lter

This is essentially the same as
#3476, except that it is applied
to the recruit dialog rather than the recall dialog.

@jostephd jostephd added this to the 1.14.7 milestone Mar 5, 2019

@jostephd jostephd merged commit f1dc9c4 into wesnoth:master Mar 5, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

jostephd added a commit that referenced this pull request Mar 5, 2019

@jostephd

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Merged, backported, and added to changelog. Thanks for the pull request!

There's also a variant of this issue in the campaign selection screen: if no campaign is selected, it starts AToTB (probably because AToTB is sorted first by default).

@addaleax addaleax deleted the addaleax:recruit-filter-no-match branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.