Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre attack event #4075 #4083

Open
wants to merge 1 commit into
base: master
from

Conversation

@spixi
Copy link
Contributor

commented May 16, 2019

This implements #4075

@@ -1339,6 +1339,25 @@ void attack::perform()
return;
}

bc_.reset(new battle_context(units_, a_.loc_, d_.loc_, a_.weapon_, d_.weapon_));

This comment has been minimized.

Copy link
@jostephd

jostephd Jun 21, 2019

Member

Shouldn't the VALIDATE(a_.weapon_ < ...) be moved up to be before this line?

This comment has been minimized.

Copy link
@spixi

spixi Jun 21, 2019

Author Contributor

I guess no, because you can change the selected attack in the pre_attack event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.