Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add documentation for bool_ability and combat_ability(for 1.15/16 version) #4087

Open
wants to merge 2 commits into
base: master
from

Conversation

@newfrenchy83
Copy link
Contributor

commented May 20, 2019

No description provided.

newfrenchy83 added some commits May 20, 2019

@newfrenchy83 newfrenchy83 reopened this May 21, 2019

@newfrenchy83 newfrenchy83 changed the title add documentation for bool_ability and combat_ability add documentation for bool_ability and combat_ability(for 1.16/16 version) Jun 15, 2019

@newfrenchy83 newfrenchy83 changed the title add documentation for bool_ability and combat_ability(for 1.16/16 version) add documentation for bool_ability and combat_ability(for 1.15/16 version) Jun 15, 2019

@newfrenchy83

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Don't forget me, please!

@jostephd

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

@newfrenchy83 Thanks for the bump. The functions in question were added in 7f7217c. @GregoryLundberg any chance you can have a look at this PR?

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

This is pretty terrible as documentation. It does look like it describes what each of the functions do, but it's kinda rambling and not very easy to understand.

As a starting point, the documentation should be made to use Doxygen markers to individually explain the purpose of each parameter and the return value.

@newfrenchy83 newfrenchy83 changed the title add documentation for bool_ability and combat_ability(for 1.15/16 version) WIP add documentation for bool_ability and combat_ability(for 1.15/16 version) Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.