Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loyal units always get the ring overlay, fix #4058 #4097

Open
wants to merge 1 commit into
base: master
from

Conversation

@spixi
Copy link
Contributor

commented May 30, 2019

No description provided.

@gfgtdf

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

There are some cases even in mainline where authors don't want the ring overlay, in particular when they have already another overlay (the hero overlay usually)

Also, I am already working on this #4088 (don't have that much time do it'll take a while)

@GregoryLundberg

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

We should reject deprecating {IS_LOYAL}.

I won't close this myself, but suggest someone working the problem (@gfgtdf?) should.

@newfrenchy83

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

i know what the method in #4081 is not ideal but it is the less heavy for the wml reworking and permit to use another overlay what ring overlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.