Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use the MP Moderators forum group to check for mod authority. #4136
People who have MP mod authority for testing or other reasons can continue to use the existing user_is_moderator column check, but for people who are supposed to moderate the server, now the forum group will be used.
This will make it easier to add/remove people to/from the group, and also ensure that the list of actual moderators matches up with the list available to users.
New config attributes added for this are:
Re-PR of #3964 so I can put this in a separate branch of my fork.
I am also waiting for this before continuing with some additional changes I would like to implement/enforce such as this.
It's not - standard-conforming SQL uses "double quotes" to wrap identifiers, rather than `backquotes` (MySQL) or [square brackets] (MSSQL).
But yeah, this code is just directly using the MySQL API, so while it would be nice to have something that works for any database system, that has no relation to this pull request.
Yeah, that was my point. The standard-conforming way is to use double quotes for identifiers and single quotes for strings.
Or a name beginning with a digit, or containing special characters. I'd say it's good practice to use it when splicing in a table or column name from a configuration file.