Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also require observers to enter a game's password. #4138

Merged
merged 1 commit into from Jun 29, 2019

Conversation

@Pentarctagon
Copy link
Member

commented Jun 28, 2019

Current situation:

  • All observers allowed (Observers checked).
  • No observers allowed (Observers unchecked).

New situation:

  • All observers allowed (Observers checked, no password set).
  • Some observers allowed (Observers checked, password set).
  • No observers allowed (Observers unchecked).

@jostephd jostephd added this to the 1.14.9 milestone Jun 28, 2019

@Pentarctagon Pentarctagon force-pushed the Pentarctagon:observer-password branch from 63d1422 to 62fb61a Jun 28, 2019

Also require observers to enter a game's password.
Current situation:
* All observers allowed (Observers checked).
* No observers allowed (Observers unchecked).

New situation:
* All observers allowed (Observers checked, no password set).
* Some observers allowed (Observers checked, password set).
* No observers allowed (Observers unchecked).

@Pentarctagon Pentarctagon force-pushed the Pentarctagon:observer-password branch from 62fb61a to 25ad08b Jun 28, 2019

@soliton- soliton- added Enhancement and removed Bug labels Jun 29, 2019

@soliton-

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

I guess the previous functionality is not really needed since the host can put observers in/change sides how he wants to anyway in a passwordless game.

@soliton- soliton- merged commit 4ac5d96 into wesnoth:master Jun 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.