Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display when observers share IP addresses as well. #4140

Merged
merged 1 commit into from Jun 29, 2019

Conversation

@Pentarctagon
Copy link
Member

commented Jun 28, 2019

Currently, if someone observes with two accounts and then one account becomes a player, at no point is any message displayed about the two accounts having the same IP.
With this change a message will now also be displayed when two observers share an IP address.

Display when observers share IP addresses as well.
Currently, if someone observes with two accounts and then one account becomes a player, at no point is any message displayed about the two accounts having the same IP.
With this change a message will now also be displayed when two observers share an IP address.

@Pentarctagon Pentarctagon added the MP label Jun 28, 2019

@soliton- soliton- merged commit 8def869 into wesnoth:master Jun 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

You forgot to update the doc comment for has_same_ip - it still references the removed parameter.

@Pentarctagon

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@CelticMinstrel Updated it in 4a5db39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.