Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If text is too long to render, fall back to line-by-line (fixes: #3265) #4207

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@stevecotton
Copy link
Contributor

commented Aug 7, 2019

This still requires a huge surface to render all of the text on to,
but is an easier fix for #3265 than redesigning the credits screen.

This removes the only caller of utils::vertical_split, which is why
that utility function is also removed.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Does line-by-line mean it displays only one line at a time, or am I completely misunderstanding that?

@stevecotton

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

It doesn't change the UI - the user still sees lots of lines of text, and can scroll up and down.

It's still all on a single large SDL_Surface that's completely rendered before displaying anything to the user. The difference is just in the logic for how to generate that SDL_Surface.

If text is too long to render, fall back to line-by-line (fixes: #3265)
This still requires a huge surface to render all of the text on to,
but is an easier fix than redesigning the credits screen.

This removes the only caller of utils::vertical_split, which is why
that utility function is also removed.

@stevecotton stevecotton force-pushed the stevecotton:i3265_fixed_size_split branch from b36bef6 to 0120694 Aug 18, 2019

@stevecotton stevecotton merged commit 0120694 into wesnoth:master Aug 18, 2019

0 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@stevecotton stevecotton deleted the stevecotton:i3265_fixed_size_split branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.