Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace problematic mushroom base terrain #4216

Closed

Conversation

@slavrenyuk
Copy link

commented Aug 12, 2019

This PR is an update to this one #4185

It replaces problematic base terrains (namely Ss, Ha and Mm) which are incorrectly displayed under the ^Uf overlay. Instead of those terrains, Uu is used now. The issue is described here https://forums.wesnoth.org/viewtopic.php?p=646099#p645168

Screenshot of the problematic base terrains before the fix. Ss and Mm base is not hidden. Ha has incorrect (snowy) transition.
problematic_mushroom_base_terrains

@stevecotton

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

I'd prefer if this was fixed by fixing the graphics instead of changing the maps, because it will also affect UMC.

@nemaara

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

This should probably wait until mixed terrains are implemented (see #4213). As stevecotton says, this will break UMC and can't go in 1.14 if it simply removes terrain codes without equivalent alternatives. Even for 1.15, it would be additional work for UMC authors that might end up being unnecessary if/when mixed terrains are made after.

@jostephd jostephd requested a review from doofus-01 Aug 15, 2019

@slavrenyuk

This comment has been minimized.

Copy link
Author

commented Aug 16, 2019

#4185 was reverted, perhaps this PR should be closed.

@CelticMinstrel

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.