Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoV: Set up for translations #4265

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@stevecotton
Copy link
Contributor

stevecotton commented Aug 22, 2019

The next scons or cmake pot-update will create all of the empty .po files.

This pushes the Portuguese translation below the 70% threshold.

For the en_GB translation, AFAICS only "honor" and maybe "overwatch" need to change.

#: data/campaigns/Wings_of_Victory/scenarios/08_Wesmere.cfg:227
msgid ""
"Sssilence! I can sssee that now that we are up close, but the dragon has "
"beaten the humans and the elvesss, so do not disrespect the dragon."

This comment has been minimized.

Copy link
@stevecotton

stevecotton Aug 22, 2019

Author Contributor

@sigurdfdragon, should this be "humansss"?

BTW, I love this line. It was great in the campaign, and it's still great looking at it multiple times.

This comment has been minimized.

Copy link
@sigurdfdragon

sigurdfdragon Aug 31, 2019

Contributor

possibly

@stevecotton

This comment has been minimized.

Copy link
Contributor Author

stevecotton commented Aug 22, 2019

Checking the build failures, it seems that all the template .po files do need to be included.
@ivanovic should I include the en_GB with all strings marked as translated (and honor changed to honour)?

The Appveyor failure is unrelated, it's the removal of sample_user_handler.cpp. Will rebase with the .po files added when that's fixed.

@Wedge009

This comment has been minimized.

Copy link
Member

Wedge009 commented Aug 23, 2019

70% being the threshold as to whether or not a translation can be selected?

Let me know when it's ready - I'll still review en_GB since there's more to localisation than just spelling differences.

Copy link
Member

loonycyborg left a comment

Seems fine to me. Tried doing pot-update with this change applied and it worked. I think en_GB changes should be outside of the scope of this pr.

@stevecotton stevecotton force-pushed the stevecotton:wov_initial_pot branch from 8814b59 to e95a4bc Aug 24, 2019
@stevecotton

This comment has been minimized.

Copy link
Contributor Author

stevecotton commented Aug 24, 2019

It's now ready. All of the .po files are just templates, including the en_GB one.

70% being the threshold as to whether or not a translation can be selected?

I thought so, but was wrong. The threshold is 80% of core, without the campaigns, and the percentages in data/language are only for core without the campaigns.

The untranslated .po files have to be included, otherwise the build breaks.
@stevecotton stevecotton force-pushed the stevecotton:wov_initial_pot branch from e95a4bc to c61b9b3 Aug 27, 2019
@stevecotton stevecotton merged commit c61b9b3 into wesnoth:master Aug 27, 2019
0 of 4 checks passed
0 of 4 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@stevecotton stevecotton deleted the stevecotton:wov_initial_pot branch Aug 27, 2019
@sigurdfdragon

This comment has been minimized.

Copy link
Contributor

sigurdfdragon commented Aug 31, 2019

@stevecotton Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.