Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Add <underline> and <strikethrough> markups. #4298

Open
wants to merge 1 commit into
base: master
from

Conversation

@jostephd
Copy link
Member

commented Aug 31, 2019

I've verified that TTF_STYLE_UNDERLINE / TTF_STYLE_STRIKETHROUGH are defined in SDL_ttf 2.0.12 (the oldest we support).

No uses of underline/strikethrough are added, though @Pentarctagon suggested one on discord.

The wiki is https://wiki.wesnoth.org/HelpWML#Help_System_Topic_Markup, it's a little out of date.

@jostephd jostephd added this to the 1.16.0 milestone Aug 31, 2019

@jostephd jostephd self-assigned this Aug 31, 2019

@Vultraz

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Why? That is, what is this going to be used for?

@jostephd

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

I don't have any specific uses planned. As I mentioned, Pent proposed one possible use on IRC, but that specific one won't necessarily happen.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

uses Discord

@Wedge009

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

I realise one generally doesn't want to add stuff that doesn't get used (which is not to say this will never get used) but since we already have some basic formatting, why not have this enhancement? One downside is that it lengthens the add_text_item parameter list, but not impractically so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.